Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CFA7F1094C for ; Fri, 14 Feb 2014 20:49:59 +0000 (UTC) Received: (qmail 21749 invoked by uid 500); 14 Feb 2014 20:49:59 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 21647 invoked by uid 500); 14 Feb 2014 20:49:58 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 21574 invoked by uid 99); 14 Feb 2014 20:49:57 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Feb 2014 20:49:57 +0000 X-ASF-Spam-Status: No, hits=-1998.4 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 14 Feb 2014 20:49:56 +0000 Received: (qmail 19596 invoked by uid 99); 14 Feb 2014 20:49:35 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Feb 2014 20:49:35 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6CE741D427D; Fri, 14 Feb 2014 20:49:34 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5509124271731911270==" MIME-Version: 1.0 Subject: Re: Review Request 18141: Prepare and launch GC executor tasks asynchronously. From: "Maxim Khutornenko" To: "Maxim Khutornenko" Cc: "Bill Farner" , "Aurora" Date: Fri, 14 Feb 2014 20:49:34 -0000 Message-ID: <20140214204934.14565.55400@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Maxim Khutornenko" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/18141/ X-Sender: "Maxim Khutornenko" References: <20140214200923.14565.73568@reviews.apache.org> In-Reply-To: <20140214200923.14565.73568@reviews.apache.org> Reply-To: "Maxim Khutornenko" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============5509124271731911270== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18141/#review34542 ----------------------------------------------------------- src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java This comment seems more appropriate for the SchedulerModule where the list is created. src/main/java/org/apache/aurora/scheduler/periodic/GcExecutorLauncher.java Any particular reason you have two makeGcTask overloads? Is it just to make unit tests easier? src/main/java/org/apache/aurora/scheduler/periodic/GcExecutorLauncher.java With the async execution there is a potential of leaking offers in case task creation starts failing for any reason. Would it make sense to have a separate stat counter (e.g. scheduler_gc_offers_used) to help troubleshooting such cases? Any difference between it and the scheduler_gc_tasks_created would be a red flag. src/main/java/org/apache/aurora/scheduler/periodic/GcExecutorLauncher.java s/public// src/main/java/org/apache/aurora/scheduler/periodic/GcExecutorLauncher.java @Override - Maxim Khutornenko On Feb. 14, 2014, 8:09 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18141/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2014, 8:09 p.m.) > > > Review request for Aurora, Deprecated Use kevints and Maxim Khutornenko. > > > Bugs: AURORA-214 > https://issues.apache.org/jira/browse/AURORA-214 > > > Repository: aurora > > > Description > ------- > > This change also alters the signature to and renames TaskLauncher#createTask, since no remaining TaskLaunchers return a task. The signature change resulted in removing MesosSchedulerImpl#fitsInOffer, which turned out to be redundant in practice (GcExecutorLauncher did this internally). > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java 70ac62e6ba3566a8789f1c7b2042b8a94f5f3c02 > src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 92399cc7a38f0ddce8338d127fb7b579606f2571 > src/main/java/org/apache/aurora/scheduler/TaskLauncher.java 96a3adee537aa87402a39dba090c6bbebe6afb1f > src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 010776efe1620c13bbcff611f9c1c3272d6c776f > src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java e7a5a8377f4c8a42012e7ecb118c597a2804da40 > src/main/java/org/apache/aurora/scheduler/periodic/GcExecutorLauncher.java f0d4fbcc411dcb3642c21f51f65c89ad24c3400a > src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 92c77d53f09c39e710bd1bb3277f32d1e144e62f > src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java ecf4f90c7d635f912f90fb367dbaa11401048052 > src/test/java/org/apache/aurora/scheduler/periodic/GcExecutorLauncherTest.java 98f5aa141ecca7475274d84f50c750db6f2908b5 > > Diff: https://reviews.apache.org/r/18141/diff/ > > > Testing > ------- > > $ ./gradlew build > > > Thanks, > > Bill Farner > > --===============5509124271731911270==--