Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1ECC7100DF for ; Fri, 14 Feb 2014 18:00:47 +0000 (UTC) Received: (qmail 61225 invoked by uid 500); 14 Feb 2014 18:00:46 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 61189 invoked by uid 500); 14 Feb 2014 18:00:46 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 61179 invoked by uid 99); 14 Feb 2014 18:00:46 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Feb 2014 18:00:45 +0000 X-ASF-Spam-Status: No, hits=-1998.4 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 14 Feb 2014 18:00:42 +0000 Received: (qmail 60303 invoked by uid 99); 14 Feb 2014 18:00:20 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Feb 2014 18:00:20 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DD43C1D421C; Fri, 14 Feb 2014 18:00:18 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0847249574722319483==" MIME-Version: 1.0 Subject: Re: Review Request 18042: Adding "sla get_task_up_count command". From: "Maxim Khutornenko" To: "Brian Wickman" , "Mark Chu-Carroll" Cc: "Aurora" , "Maxim Khutornenko" Date: Fri, 14 Feb 2014 18:00:18 -0000 Message-ID: <20140214180018.14565.74995@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Maxim Khutornenko" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/18042/ X-Sender: "Maxim Khutornenko" References: <20140214175134.14565.42541@reviews.apache.org> In-Reply-To: <20140214175134.14565.42541@reviews.apache.org> Reply-To: "Maxim Khutornenko" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============0847249574722319483== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On Feb. 14, 2014, 5:51 p.m., Brian Wickman wrote: > > src/main/python/apache/aurora/client/cli/options.py, lines 55-58 > > > > > > one-liner: > > return sorted(map(parse_time, time_values.split(','))) > > > > Great idea. Done. - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18042/#review34513 ----------------------------------------------------------- On Feb. 14, 2014, 5:42 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18042/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2014, 5:42 p.m.) > > > Review request for Aurora, Mark Chu-Carroll and Brian Wickman. > > > Bugs: AURORA-206 > https://issues.apache.org/jira/browse/AURORA-206 > > > Repository: aurora > > > Description > ------- > > Implementing api and cli logic for the get_task_up_count command. > > > Diffs > ----- > > src/main/python/apache/aurora/client/api/BUILD 69229a87698ed7e99957cd74364bb2ed6b93c6a3 > src/main/python/apache/aurora/client/api/__init__.py 8bc05e20e34aa3266c2a9c5f24a1cfec8adaf24d > src/main/python/apache/aurora/client/api/sla.py PRE-CREATION > src/main/python/apache/aurora/client/cli/BUILD f5c9ae75d7a26883d90b9bd8ac9c80cd436d03a1 > src/main/python/apache/aurora/client/cli/client.py e416d3879cc5943ec5ab3931a8b1aedb85a379a9 > src/main/python/apache/aurora/client/cli/options.py 5d6eba2abc55954fddb0c8bc1fe4de4f6d089962 > src/main/python/apache/aurora/client/cli/sla.py PRE-CREATION > src/test/python/apache/aurora/client/api/BUILD 9833535bd6a25d6409abe584056152e1ac84548e > src/test/python/apache/aurora/client/api/test_sla.py PRE-CREATION > src/test/python/apache/aurora/client/cli/BUILD c106b97a0902da5cd791b18117da3198bfb43b8c > src/test/python/apache/aurora/client/cli/test_sla.py PRE-CREATION > > Diff: https://reviews.apache.org/r/18042/diff/ > > > Testing > ------- > > ./pants src/test/python/apache/aurora/client:all > > > Thanks, > > Maxim Khutornenko > > --===============0847249574722319483==--