Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 46E39103FD for ; Thu, 13 Feb 2014 18:56:49 +0000 (UTC) Received: (qmail 5816 invoked by uid 500); 13 Feb 2014 18:56:48 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 5781 invoked by uid 500); 13 Feb 2014 18:56:48 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 5767 invoked by uid 99); 13 Feb 2014 18:56:48 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Feb 2014 18:56:48 +0000 X-ASF-Spam-Status: No, hits=-1998.4 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 13 Feb 2014 18:56:47 +0000 Received: (qmail 4906 invoked by uid 99); 13 Feb 2014 18:56:26 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Feb 2014 18:56:26 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B893A1D4223; Thu, 13 Feb 2014 18:56:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5870802008475529621==" MIME-Version: 1.0 Subject: Re: Review Request 18036: Added LeaderRedirectFilter to scheduler home page. From: "Bill Farner" To: "Bill Farner" , "Kevin Sweeney" Cc: "Aurora" , "Suman Karumuri" Date: Thu, 13 Feb 2014 18:56:25 -0000 Message-ID: <20140213185625.22558.83303@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/18036/ X-Sender: "Bill Farner" References: <20140212232612.12058.22014@reviews.apache.org> In-Reply-To: <20140212232612.12058.22014@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============5870802008475529621== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18036/#review34399 ----------------------------------------------------------- Ship it! LGTM mod redundant logging. - Bill Farner On Feb. 12, 2014, 11:26 p.m., Suman Karumuri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18036/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2014, 11:26 p.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Bugs: AURORA-211 > https://issues.apache.org/jira/browse/AURORA-211 > > > Repository: aurora > > > Description > ------- > > Also added additional logging to UIRedirectFilter to expose the order in which filters are being applied. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/http/ServletModule.java ba37e26bba4e1ad4c546e73748182deb2d5942a7 > src/main/java/org/apache/aurora/scheduler/http/UIRedirectFilter.java b35aad8db006133ba70692e43db1f083d4950914 > > Diff: https://reviews.apache.org/r/18036/diff/ > > > Testing > ------- > > gradle clean build > tested on localhost, verified behavior via log statements. > > > Thanks, > > Suman Karumuri > > --===============5870802008475529621==--