Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4025B10248 for ; Tue, 11 Feb 2014 23:00:57 +0000 (UTC) Received: (qmail 43161 invoked by uid 500); 11 Feb 2014 23:00:56 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 43129 invoked by uid 500); 11 Feb 2014 23:00:56 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 43120 invoked by uid 99); 11 Feb 2014 23:00:55 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Feb 2014 23:00:55 +0000 X-ASF-Spam-Status: No, hits=-1998.4 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 11 Feb 2014 23:00:52 +0000 Received: (qmail 41422 invoked by uid 99); 11 Feb 2014 23:00:26 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Feb 2014 23:00:26 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5F56D1D48D7; Tue, 11 Feb 2014 23:00:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8644492625696491066==" MIME-Version: 1.0 Subject: Re: Review Request 17752: Add task noun, supporting "run" and "ssh" verbs. From: "Jonathan Boulle" To: "Bill Farner" , "Brian Wickman" Cc: "Aurora" , "Mark Chu-Carroll" , "Jonathan Boulle" Date: Tue, 11 Feb 2014 23:00:25 -0000 Message-ID: <20140211230025.6237.98001@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Jonathan Boulle" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/17752/ X-Sender: "Jonathan Boulle" References: <20140207204505.31901.37602@reviews.apache.org> In-Reply-To: <20140207204505.31901.37602@reviews.apache.org> Reply-To: "Jonathan Boulle" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============8644492625696491066== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17752/#review34239 ----------------------------------------------------------- src/main/python/apache/aurora/client/cli/options.py bad merge? this still references context instead of instance_str - Jonathan Boulle On Feb. 7, 2014, 8:44 p.m., Mark Chu-Carroll wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17752/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2014, 8:44 p.m.) > > > Review request for Aurora, Bill Farner and Brian Wickman. > > > Bugs: aurora-124 > https://issues.apache.org/jira/browse/aurora-124 > > > Repository: aurora > > > Description > ------- > > Add task noun, supporting "run" and "ssh" verbs. > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/BUILD f5c9ae75d7a26883d90b9bd8ac9c80cd436d03a1 > src/main/python/apache/aurora/client/cli/client.py e416d3879cc5943ec5ab3931a8b1aedb85a379a9 > src/main/python/apache/aurora/client/cli/jobs.py caff6d824d9f43cc9eb0c738ea6bb489321d4669 > src/main/python/apache/aurora/client/cli/options.py 5d6eba2abc55954fddb0c8bc1fe4de4f6d089962 > src/main/python/apache/aurora/client/cli/task.py PRE-CREATION > src/test/python/apache/aurora/client/cli/BUILD c106b97a0902da5cd791b18117da3198bfb43b8c > src/test/python/apache/aurora/client/cli/test_task_run.py PRE-CREATION > > Diff: https://reviews.apache.org/r/17752/diff/ > > > Testing > ------- > > [sun-wukong incubator-aurora (tasknoun)]$ ./pants src/test/python/apache/aurora/client/cli:all > Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) > ============================= test session starts ============================== > platform darwin -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 > collected 25 items > > src/test/python/apache/aurora/client/cli/test_cancel_update.py .. > src/test/python/apache/aurora/client/cli/test_create.py .... > src/test/python/apache/aurora/client/cli/test_diff.py ... > src/test/python/apache/aurora/client/cli/test_kill.py ..... > src/test/python/apache/aurora/client/cli/test_restart.py ... > src/test/python/apache/aurora/client/cli/test_status.py ..... > src/test/python/apache/aurora/client/cli/test_update.py ... > > ========================== 25 passed in 1.37 seconds =========================== > ============================= test session starts ============================== > platform darwin -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 > collected 2 items > > src/test/python/apache/aurora/client/cli/test_task_run.py .. > > =========================== 2 passed in 0.30 seconds =========================== > src.test.python.apache.aurora.client.cli.job ..... SUCCESS > src.test.python.apache.aurora.client.cli.task ..... SUCCESS > > > Thanks, > > Mark Chu-Carroll > > --===============8644492625696491066==--