Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 32D73109DD for ; Tue, 11 Feb 2014 19:55:39 +0000 (UTC) Received: (qmail 40029 invoked by uid 500); 11 Feb 2014 19:55:38 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 39998 invoked by uid 500); 11 Feb 2014 19:55:38 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 39990 invoked by uid 99); 11 Feb 2014 19:55:38 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Feb 2014 19:55:38 +0000 X-ASF-Spam-Status: No, hits=-1998.4 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 11 Feb 2014 19:55:35 +0000 Received: (qmail 39445 invoked by uid 99); 11 Feb 2014 19:55:13 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Feb 2014 19:55:13 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 439201D48C9; Tue, 11 Feb 2014 19:55:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0504631990036860250==" MIME-Version: 1.0 Subject: Re: Review Request 17818: AURORA-145:Test dependencies leak into distribution From: "Bill Farner" To: "Bill Farner" , "Kevin Sweeney" Cc: "Aurora" , "Jake Farrell" Date: Tue, 11 Feb 2014 19:55:12 -0000 Message-ID: <20140211195512.29246.65308@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/17818/ X-Sender: "Bill Farner" References: <20140207014552.1219.94625@reviews.apache.org> In-Reply-To: <20140207014552.1219.94625@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============0504631990036860250== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17818/#review34224 ----------------------------------------------------------- The move into src/test is still a no-go AFAICT, since we currently expect AbstractCronIT to be published for external consumption. My personal preference is to nuke AbstractCronIT with https://reviews.apache.org/r/17750, obviating the need for this reshuffling. - Bill Farner On Feb. 7, 2014, 1:45 a.m., Jake Farrell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17818/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2014, 1:45 a.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Bugs: AURORA-145 > https://issues.apache.org/jira/browse/AURORA-145 > > > Repository: aurora > > > Description > ------- > > AURORA-145:Test dependencies leak into distribution > > First part of Aurora-145 which makes easy mock and zookeeper testing > part of the test compile only. Part two will be to look at 3rd party > dependencies and see what we can do to make the dist smaller. > > > Diffs > ----- > > build.gradle 4ba72c109b92d05581dbfe78194518653f20e12d > src/main/java/org/apache/aurora/scheduler/cron/testing/AbstractCronIT.java > src/main/java/org/apache/aurora/scheduler/storage/log/testing/LogOpMatcher.java 041d1f9937672df64864be09bbc4fd2a38b9b1ab > src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java > src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 6cfaf39ee41862d088ab9747b7820da3f5014a0c > src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java f708ab3c2fa5d50b084e037f9cc0cb998935120a > > Diff: https://reviews.apache.org/r/17818/diff/ > > > Testing > ------- > > ran all unit tests with no failures > > > Thanks, > > Jake Farrell > > --===============0504631990036860250==--