Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 97AF7100CF for ; Wed, 5 Feb 2014 23:20:03 +0000 (UTC) Received: (qmail 92488 invoked by uid 500); 5 Feb 2014 23:20:03 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 92457 invoked by uid 500); 5 Feb 2014 23:20:02 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 92449 invoked by uid 99); 5 Feb 2014 23:20:02 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Feb 2014 23:20:02 +0000 X-ASF-Spam-Status: No, hits=-1998.3 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 05 Feb 2014 23:20:01 +0000 Received: (qmail 91965 invoked by uid 99); 5 Feb 2014 23:19:41 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Feb 2014 23:19:40 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 273CF1D47A9; Wed, 5 Feb 2014 23:19:40 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0673540409824347874==" MIME-Version: 1.0 Subject: Re: Review Request 17749: Refactor CronScheduler interfaces to use Guava Service. From: "Kevin Sweeney" To: "Bill Farner" , "Maxim Khutornenko" Cc: "Aurora" , "Kevin Sweeney" Date: Wed, 05 Feb 2014 23:19:40 -0000 Message-ID: <20140205231940.1219.95089@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Kevin Sweeney" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/17749/ X-Sender: "Kevin Sweeney" References: <20140205203155.1218.21092@reviews.apache.org> In-Reply-To: <20140205203155.1218.21092@reviews.apache.org> Reply-To: "Kevin Sweeney" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============0673540409824347874== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17749/ ----------------------------------------------------------- (Updated Feb. 5, 2014, 3:19 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Changes ------- rebase to master Bugs: AURORA-132 https://issues.apache.org/jira/browse/AURORA-132 Repository: aurora Description ------- Refactor CronScheduler interfaces to use Guava Service. Also, some methods from AbstractCronIT were dropped as they were not necessary in practice. Diffs (updated) ----- src/main/java/org/apache/aurora/scheduler/cron/CronScheduler.java 34e174924a71b5acb3debc0b7911b61fab3484e0 src/main/java/org/apache/aurora/scheduler/cron/noop/NoopCronScheduler.java bbee5efce8e4885b66ad31ec3072035d94e0d14e src/main/java/org/apache/aurora/scheduler/cron/testing/AbstractCronIT.java 076a7458126d4c7892289d8f5d79a78a9efc4276 src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java 6d162862252cb23497d8a345485d515eccc781d0 src/test/java/org/apache/aurora/scheduler/cron/noop/NoopCronIT.java 94441b8f7a66c1eabc542e56275f3b32cf536684 src/test/java/org/apache/aurora/scheduler/state/CronJobManagerTest.java 462e64f1d6a57724ed51953149dd151081b63115 Diff: https://reviews.apache.org/r/17749/diff/ Testing ------- ./gradlew build Thanks, Kevin Sweeney --===============0673540409824347874==--