Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1069110500 for ; Wed, 5 Feb 2014 07:15:16 +0000 (UTC) Received: (qmail 45114 invoked by uid 500); 5 Feb 2014 07:15:15 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 45083 invoked by uid 500); 5 Feb 2014 07:15:13 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 45074 invoked by uid 99); 5 Feb 2014 07:15:12 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Feb 2014 07:15:12 +0000 X-ASF-Spam-Status: No, hits=-1998.3 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 05 Feb 2014 07:15:09 +0000 Received: (qmail 44906 invoked by uid 99); 5 Feb 2014 07:14:48 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Feb 2014 07:14:48 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 67CE41C0486; Wed, 5 Feb 2014 07:14:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7295041816374602063==" MIME-Version: 1.0 Subject: Re: Review Request 17730: Now sorting roles before displaying them on home page. From: "Suman Karumuri" To: "Bill Farner" , "Kevin Sweeney" Cc: "Aurora" , "Suman Karumuri" Date: Wed, 05 Feb 2014 07:14:47 -0000 Message-ID: <20140205071447.26209.25213@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Suman Karumuri" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/17730/ X-Sender: "Suman Karumuri" References: <20140205013849.26209.62878@reviews.apache.org> In-Reply-To: <20140205013849.26209.62878@reviews.apache.org> Reply-To: "Suman Karumuri" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============7295041816374602063== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17730/ ----------------------------------------------------------- (Updated Feb. 5, 2014, 7:14 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes ------- Now showing up and down icons on sort. Fixed a jquery loading issue. Bugs: AURORA-190 https://issues.apache.org/jira/browse/AURORA-190 Repository: aurora Description ------- Now sorting roles before displaying them on home page to match the old UI behavior. Diffs (updated) ----- src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 9a2fdf103c7c6e4387464a05a151e3d842f90e12 src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 2601da9ef64ef91cbf9db9b6f12a8d2cdbb0c297 src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 0abd3e737e901f08d18c3ceb55ea2f94847cc2e1 Diff: https://reviews.apache.org/r/17730/diff/ Testing ------- gradle clean build. gradle run with fake summary data. Thanks, Suman Karumuri --===============7295041816374602063==--