Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7046C102FE for ; Tue, 4 Feb 2014 22:02:24 +0000 (UTC) Received: (qmail 14913 invoked by uid 500); 4 Feb 2014 22:02:23 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 14886 invoked by uid 500); 4 Feb 2014 22:02:22 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 14874 invoked by uid 99); 4 Feb 2014 22:02:21 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Feb 2014 22:02:21 +0000 X-ASF-Spam-Status: No, hits=-1998.3 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 04 Feb 2014 22:02:18 +0000 Received: (qmail 12220 invoked by uid 99); 4 Feb 2014 22:01:56 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Feb 2014 22:01:56 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6D5301D4763; Tue, 4 Feb 2014 22:01:56 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9055901931042858412==" MIME-Version: 1.0 Subject: Re: Review Request 17724: Add an exception catch to provide a better error message when distributed command runner fails From: "Kevin Sweeney" To: "Brian Wickman" , "Kevin Sweeney" Cc: "Aurora" , "Mark Chu-Carroll" Date: Tue, 04 Feb 2014 22:01:56 -0000 Message-ID: <20140204220156.14639.51292@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Kevin Sweeney" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/17724/ X-Sender: "Kevin Sweeney" References: <20140204214917.3575.47969@reviews.apache.org> In-Reply-To: <20140204214917.3575.47969@reviews.apache.org> Reply-To: "Kevin Sweeney" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============9055901931042858412== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17724/#review33647 ----------------------------------------------------------- src/main/python/apache/aurora/client/api/command_runner.py It's unclear why this should be an API-level check instead of a higher-level CLI check verifying that cluster selected expresses the trait required to use the DCR. Also, this error message isn't informative (which parameters do I need to define? where do I define them?) - Kevin Sweeney On Feb. 4, 2014, 1:49 p.m., Mark Chu-Carroll wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17724/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2014, 1:49 p.m.) > > > Review request for Aurora, Kevin Sweeney and Brian Wickman. > > > Bugs: aurora-128 > https://issues.apache.org/jira/browse/aurora-128 > > > Repository: aurora > > > Description > ------- > > Add an exception catch to provide a better error message when distributed command runner fails due to un-specified executor parameters in the slave configurations. > > > Diffs > ----- > > src/main/python/apache/aurora/client/api/command_runner.py c645e9556b50b332cc5a298ceee3d9188a68a727 > src/test/python/apache/aurora/client/commands/test_run.py abcc275d57373038227d3805c16b17b967f92048 > > Diff: https://reviews.apache.org/r/17724/diff/ > > > Testing > ------- > > Manual testing on the command line. > > > Thanks, > > Mark Chu-Carroll > > --===============9055901931042858412==--