Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9C906100FA for ; Tue, 4 Feb 2014 21:27:33 +0000 (UTC) Received: (qmail 35052 invoked by uid 500); 4 Feb 2014 21:27:32 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 35023 invoked by uid 500); 4 Feb 2014 21:27:32 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 35015 invoked by uid 99); 4 Feb 2014 21:27:32 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Feb 2014 21:27:32 +0000 X-ASF-Spam-Status: No, hits=-1998.3 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 04 Feb 2014 21:27:31 +0000 Received: (qmail 34960 invoked by uid 99); 4 Feb 2014 21:27:11 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Feb 2014 21:27:11 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A5CF01D4763; Tue, 4 Feb 2014 21:27:10 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3978418557525264401==" MIME-Version: 1.0 Subject: Review Request 17724: Add an exception catch to provide a better error message when distributed command runner fails due to un-specified executor parameters in the slave configurations. From: "Mark Chu-Carroll" To: "Brian Wickman" , "Kevin Sweeney" Cc: "Aurora" , "Mark Chu-Carroll" Date: Tue, 04 Feb 2014 21:27:10 -0000 Message-ID: <20140204212710.3575.64715@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Mark Chu-Carroll" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/17724/ X-Sender: "Mark Chu-Carroll" Reply-To: "Mark Chu-Carroll" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============3978418557525264401== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17724/ ----------------------------------------------------------- Review request for Aurora, Kevin Sweeney and Brian Wickman. Bugs: aurora-128 https://issues.apache.org/jira/browse/aurora-128 Repository: aurora Description ------- Add an exception catch to provide a better error message when distributed command runner fails due to un-specified executor parameters in the slave configurations. Diffs ----- src/main/python/apache/aurora/client/api/command_runner.py c645e9556b50b332cc5a298ceee3d9188a68a727 src/test/python/apache/aurora/client/commands/test_run.py abcc275d57373038227d3805c16b17b967f92048 Diff: https://reviews.apache.org/r/17724/diff/ Testing ------- Manual testing on the command line. Thanks, Mark Chu-Carroll --===============3978418557525264401==--