Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 16A5E10DCB for ; Tue, 4 Feb 2014 20:38:02 +0000 (UTC) Received: (qmail 20402 invoked by uid 500); 4 Feb 2014 20:38:01 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 20373 invoked by uid 500); 4 Feb 2014 20:38:01 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 20362 invoked by uid 99); 4 Feb 2014 20:38:00 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Feb 2014 20:38:00 +0000 X-ASF-Spam-Status: No, hits=-1998.3 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 04 Feb 2014 20:37:58 +0000 Received: (qmail 19432 invoked by uid 99); 4 Feb 2014 20:37:36 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Feb 2014 20:37:36 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8253B1D4763; Tue, 4 Feb 2014 20:37:35 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3914007360399205661==" MIME-Version: 1.0 Subject: Re: Review Request 17672: Add indices to OfferQueueImpl to improve resource offer handling performance. From: "Bill Farner" To: "Maxim Khutornenko" , "Suman Karumuri" Cc: "Bill Farner" , "Aurora" Date: Tue, 04 Feb 2014 20:37:35 -0000 Message-ID: <20140204203735.3575.43520@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/17672/ X-Sender: "Bill Farner" References: <20140204192217.3575.60274@reviews.apache.org> In-Reply-To: <20140204192217.3575.60274@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============3914007360399205661== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On Feb. 4, 2014, 7:22 p.m., Suman Karumuri wrote: > > The logic is much cleaner now. > > > > Since no new tests are added, what is the code coverage of this class before and after this change? > > Bill Farner wrote: > I will check on this and report back. By the numbers, coverage is slightly lower (89% vs 92%), but that's a result of the same work being done with less code (e.g. predicates are gone). There are no new lines of code that are not covered. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17672/#review33625 ----------------------------------------------------------- On Feb. 4, 2014, 6:41 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17672/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2014, 6:41 p.m.) > > > Review request for Aurora, Suman Karumuri and Maxim Khutornenko. > > > Bugs: AURORA-153 > https://issues.apache.org/jira/browse/AURORA-153 > > > Repository: aurora > > > Description > ------- > > Add indices to OfferQueueImpl to improve resource offer handling performance. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 85bd0a63da122e7daf2f4a12938fef043136f461 > > Diff: https://reviews.apache.org/r/17672/diff/ > > > Testing > ------- > > ./gradlew build > > > Thanks, > > Bill Farner > > --===============3914007360399205661==--