Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A14431071D for ; Tue, 4 Feb 2014 00:51:55 +0000 (UTC) Received: (qmail 82962 invoked by uid 500); 4 Feb 2014 00:51:55 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 82937 invoked by uid 500); 4 Feb 2014 00:51:54 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 82929 invoked by uid 99); 4 Feb 2014 00:51:54 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Feb 2014 00:51:54 +0000 X-ASF-Spam-Status: No, hits=-1998.3 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 04 Feb 2014 00:51:52 +0000 Received: (qmail 82901 invoked by uid 99); 4 Feb 2014 00:51:29 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Feb 2014 00:51:29 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5F2E51D477F; Tue, 4 Feb 2014 00:51:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8956488295164320753==" MIME-Version: 1.0 Subject: Re: Review Request 17679: Upgrade twitter.common.python to 0.3.0 From: "Kevin Sweeney" To: "Brian Wickman" Cc: "Aurora" , "Kevin Sweeney" Date: Tue, 04 Feb 2014 00:51:29 -0000 Message-ID: <20140204005129.14639.95242@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Kevin Sweeney" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/17679/ X-Sender: "Kevin Sweeney" References: <20140204003427.14639.48418@reviews.apache.org> In-Reply-To: <20140204003427.14639.48418@reviews.apache.org> Reply-To: "Kevin Sweeney" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============8956488295164320753== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On Feb. 3, 2014, 4:34 p.m., Brian Wickman wrote: > > pants, line 20 > > > > > > why not PANTS_VERSION=$(cat .pantsversion) like before? This matches the convention in other virtualenv-y scripts, but I don't have strong feelings one way or another. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17679/#review33543 ----------------------------------------------------------- On Feb. 3, 2014, 3:13 p.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17679/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2014, 3:13 p.m.) > > > Review request for Aurora and Brian Wickman. > > > Repository: aurora > > > Description > ------- > > Upgrade twitter.common.python to 0.3.0 > > Use the new "pex" utility from twitter.common.python to bootstrap pants > rather than relying on knowledge of the inner workings of > twitter.common.python APIs. I also took the opportunity to refactor the > common "maybe bootstrap a virtualenv" pattern used with some support > tools to use a consistent build-support/NAME.venv pattern. > > > Diffs > ----- > > .gitignore 25114b9fe41747b60de2d176f959ff26571f0062 > build-support/pex PRE-CREATION > build-support/release/make-python-sdists b2314d72249fee81e434a220a75cbc8588495c5a > pants 229e201b8fa7b069eee4291695ce341318ef976e > rbt 8828ead987ba84ef8d7435b30b7ff99a1d5e20a1 > > Diff: https://reviews.apache.org/r/17679/diff/ > > > Testing > ------- > > Ran ./pants, ./rbt, ./build-support/pex, ./build-support/release/make-python-sdists from clean and dirty repos. > > ./pants src/test/python:all > > > Thanks, > > Kevin Sweeney > > --===============8956488295164320753==--