aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Suman Karumuri <ma...@apache.org>
Subject Re: Review Request 17672: Add indices to OfferQueueImpl to improve resource offer handling performance.
Date Tue, 04 Feb 2014 21:41:23 GMT
Cool. Thanks!


On Tue, Feb 4, 2014 at 12:37 PM, Bill Farner <wfarner@apache.org> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17672/
>
> On February 4th, 2014, 7:22 p.m. UTC, *Suman Karumuri* wrote:
>
> The logic is much cleaner now.
>
> Since no new tests are added, what is the code coverage of this class before and after
this change?
>
>  On February 4th, 2014, 7:56 p.m. UTC, *Bill Farner* wrote:
>
> I will check on this and report back.
>
>  By the numbers, coverage is slightly lower (89% vs 92%), but that's a result of the
same work being done with less code (e.g. predicates are gone).  There are no new lines of
code that are not covered.
>
>
> - Bill
>
> On February 4th, 2014, 6:41 p.m. UTC, Bill Farner wrote:
>   Review request for Aurora, Suman Karumuri and Maxim Khutornenko.
> By Bill Farner.
>
> *Updated Feb. 4, 2014, 6:41 p.m.*
>  *Bugs: * AURORA-153 <https://issues.apache.org/jira/browse/AURORA-153>
>  *Repository: * aurora
> Description
>
> Add indices to OfferQueueImpl to improve resource offer handling performance.
>
>   Testing
>
> ./gradlew build
>
>   Diffs
>
>    - src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java
>    (85bd0a63da122e7daf2f4a12938fef043136f461)
>
> View Diff <https://reviews.apache.org/r/17672/diff/>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message