aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 17347: Added non-prod consumption info to getQuota call.
Date Fri, 28 Feb 2014 23:54:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17347/#review35871
-----------------------------------------------------------

Ship it!



src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
<https://reviews.apache.org/r/17347/#comment66666>

    Mind making this a different value, to prove that the implementation treats them differently?


- Bill Farner


On Feb. 28, 2014, 11:32 p.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17347/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2014, 11:32 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-65
>     https://issues.apache.org/jira/browse/AURORA-65
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This call will be used by the role page in the UI.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7b9f185cea77825e46ecfc588c72e146cd864a32

>   src/main/thrift/org/apache/aurora/gen/api.thrift 3ee24c75f961af61048a78ec6c3f244361bed5bd

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
dc557718269064a202c3e4eb1272ff2b9f209ad9 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 4e6c51d9298bf6fc1935ec9080f38726f79e7959

> 
> Diff: https://reviews.apache.org/r/17347/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew clean build.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message