aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 18345: AURORA-225: Shell scripts in checkout should use an absolute path
Date Tue, 25 Feb 2014 02:31:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18345/#review35366
-----------------------------------------------------------



pants
<https://reviews.apache.org/r/18345/#comment65841>

    Should be quoted in case $HERE is a directory containing spaces.



pants
<https://reviews.apache.org/r/18345/#comment65842>

    Same as above - $HERE should be within double-quotes to avoid issues like
    
    ksweeney@ksweeney-ThinkCentre-M93p:~/workspace/aurora$ cmd="echo test"
    ksweeney@ksweeney-ThinkCentre-M93p:~/workspace/aurora$ $cmd
    test
    ksweeney@ksweeney-ThinkCentre-M93p:~/workspace/aurora$ 
    


Nit about quoting applied to each file.

- Kevin Sweeney


On Feb. 24, 2014, 6:21 p.m., Dan Norris wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18345/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2014, 6:21 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-225
>     https://issues.apache.org/jira/browse/AURORA-225
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-225: Shell scripts in checkout should use an absolute path
> 
> 
> Diffs
> -----
> 
>   build-support/pex cd083d996884681acf6f731ed24037342f2309bf 
>   build-support/virtualenv d7a99e0c3934afba55e131850a202b6e706cec8a 
>   pants 4dc17fd365d8fd120c162905c41f29d92788011f 
>   rbt c03c4c4b61fb49fecd7e3bbff89581ca91c58a74 
> 
> Diff: https://reviews.apache.org/r/18345/diff/
> 
> 
> Testing
> -------
> 
> Submitted this review with the following command:
>  ../rbt post -o -g (from inside of build-support directory)
> 
> 
> Thanks,
> 
> Dan Norris
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message