aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe Smith" <yasumo...@gmail.com>
Subject Re: Review Request 18334: Move and unit test Maintenance module and commands
Date Mon, 24 Feb 2014 18:19:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18334/
-----------------------------------------------------------

(Updated Feb. 24, 2014, 10:19 a.m.)


Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Brian Wickman.


Bugs: AURORA-223
    https://issues.apache.org/jira/browse/AURORA-223


Repository: aurora


Description
-------

As always, feel free to tear it apart.

I plan to add tests for the other commands as well, but wanted to get this out sooner than
later to ensure others agreed with my approach.


Diffs (updated)
-----

  src/main/python/apache/aurora/admin/BUILD 480dad69d8122168a6b7222ef9df0eb689fae386 
  src/main/python/apache/aurora/admin/mesos_maintenance.py d8ffdec062db07ce82556fb38ff4a5eea7921953

  src/main/python/apache/aurora/client/bin/BUILD dbabfd0e56288d04c399e20976ea6e0287112d91

  src/main/python/apache/aurora/client/commands/BUILD 14bbdd4d0cb0e8e5102e75baef4e8b34d98967c0

  src/main/python/apache/aurora/client/commands/admin.py 989c5b625b48fe67ef1297ceda8d7e35cb8ead7e

  src/main/python/apache/aurora/client/commands/maintenance.py PRE-CREATION 
  src/test/python/apache/aurora/admin/BUILD 258b1eb58a4eec1650bfd317823f76a30889f912 
  src/test/python/apache/aurora/admin/test_mesos_maintenance.py 000fbe5a873669bf55a9110f1aa6f1d7c8350ef8

  src/test/python/apache/aurora/client/commands/BUILD 6d448d7320a78bf140873b743805846c179281a7

  src/test/python/apache/aurora/client/commands/test_maintenance.py PRE-CREATION 

Diff: https://reviews.apache.org/r/18334/diff/


Testing
-------

./pants ./src/test/python/apache/aurora:all

particularly:

src.test.python.apache.aurora.client.commands.maintenance                       .....   SUCCESS


Thanks,

Joe Smith


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message