aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe Smith" <yasumo...@gmail.com>
Subject Re: Review Request 18334: Move and unit test Maintenance module and commands
Date Mon, 24 Feb 2014 07:07:01 GMT


> On Feb. 21, 2014, 9:43 a.m., Brian Wickman wrote:
> > src/main/python/apache/aurora/client/base.py, lines 43-44
> > <https://reviews.apache.org/r/18334/diff/1/?file=499595#file499595line43>
> >
> >     ?

fixed, thx.


> On Feb. 21, 2014, 9:43 a.m., Brian Wickman wrote:
> > src/main/python/apache/aurora/client/commands/maintenance.py, lines 24-25
> > <https://reviews.apache.org/r/18334/diff/1/?file=499599#file499599line24>
> >
> >     nope

wow.


> On Feb. 21, 2014, 9:43 a.m., Brian Wickman wrote:
> > src/test/python/apache/aurora/client/commands/test_maintenance.py, lines 23-28
> > <https://reviews.apache.org/r/18334/diff/1/?file=499603#file499603line23>
> >
> >     indent 4 and have trailing comma on the last import (in case we add imports
and want to re-sort.)

done, thanks!


> On Feb. 21, 2014, 9:43 a.m., Brian Wickman wrote:
> > src/test/python/apache/aurora/client/commands/test_maintenance.py, line 41
> > <https://reviews.apache.org/r/18334/diff/1/?file=499603#file499603line41>
> >
> >     be consistent with ' and ".  we usually use '

done


> On Feb. 21, 2014, 9:43 a.m., Brian Wickman wrote:
> > src/test/python/apache/aurora/client/commands/test_maintenance.py, line 47
> > <https://reviews.apache.org/r/18334/diff/1/?file=499603#file499603line47>
> >
> >     no ws after [ and before ]

gotcha.


> On Feb. 21, 2014, 9:43 a.m., Brian Wickman wrote:
> > src/test/python/apache/aurora/client/commands/test_maintenance.py, line 49
> > <https://reviews.apache.org/r/18334/diff/1/?file=499603#file499603line49>
> >
> >     kill nl

done.


- Joe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18334/#review35160
-----------------------------------------------------------


On Feb. 20, 2014, 4:05 p.m., Joe Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18334/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2014, 4:05 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Brian Wickman.
> 
> 
> Bugs: AURORA-223
>     https://issues.apache.org/jira/browse/AURORA-223
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> As always, feel free to tear it apart.
> 
> I plan to add tests for the other commands as well, but wanted to get this out sooner
than later to ensure others agreed with my approach.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/admin/BUILD 480dad69d8122168a6b7222ef9df0eb689fae386

>   src/main/python/apache/aurora/admin/mesos_maintenance.py d8ffdec062db07ce82556fb38ff4a5eea7921953

>   src/main/python/apache/aurora/client/base.py c5c969f9641c8e0e1604648b1f9ed542ab59b7d0

>   src/main/python/apache/aurora/client/bin/BUILD dbabfd0e56288d04c399e20976ea6e0287112d91

>   src/main/python/apache/aurora/client/commands/BUILD 14bbdd4d0cb0e8e5102e75baef4e8b34d98967c0

>   src/main/python/apache/aurora/client/commands/admin.py 45686aec8d69f0dfa1d649a92a19ca87bd315823

>   src/main/python/apache/aurora/client/commands/maintenance.py PRE-CREATION 
>   src/test/python/apache/aurora/admin/BUILD 258b1eb58a4eec1650bfd317823f76a30889f912

>   src/test/python/apache/aurora/admin/test_mesos_maintenance.py 000fbe5a873669bf55a9110f1aa6f1d7c8350ef8

>   src/test/python/apache/aurora/client/commands/BUILD 02c27aa513d60ef901f446c56cbfc0d891445e30

>   src/test/python/apache/aurora/client/commands/test_maintenance.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18334/diff/
> 
> 
> Testing
> -------
> 
> ./pants ./src/test/python/apache/aurora:all
> 
> particularly:
> 
> src.test.python.apache.aurora.client.commands.maintenance                       .....
  SUCCESS
> 
> 
> Thanks,
> 
> Joe Smith
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message