aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Wickman" <wick...@apache.org>
Subject Re: Review Request 18296: Adding admin_client sla_list_safe_domain command.
Date Fri, 21 Feb 2014 23:01:53 GMT


> On Feb. 21, 2014, 7:48 p.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/api/sla.py, lines 135-139
> > <https://reviews.apache.org/r/18296/diff/2/?file=500057#file500057line135>
> >
> >     The else would fire even if the _hosts is empty producing an unbound variable
error. I would have to add an extra check before the loop for this to work, which I'd rather
not.

i don't think so, right?  the 'if safe' is in the inner loop where safe_limits is defined
as []


- Brian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18296/#review35182
-----------------------------------------------------------


On Feb. 21, 2014, 7:49 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18296/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2014, 7:49 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
> 
> 
> Bugs: AURORA-208
>     https://issues.apache.org/jira/browse/AURORA-208
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implemented admin_client sla_list_safe_domain command.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/__init__.py 0999b6f99bd74361663258cdae9d3920b3bb636f

>   src/main/python/apache/aurora/client/api/sla.py b0b2b245951ea72d113ff2b3969c4d54024f73e7

>   src/main/python/apache/aurora/client/commands/admin.py 45686aec8d69f0dfa1d649a92a19ca87bd315823

>   src/test/python/apache/aurora/client/api/test_sla.py 2e6c8faf668182b497df59fe41b74af240459de7

>   src/test/python/apache/aurora/client/commands/BUILD 02c27aa513d60ef901f446c56cbfc0d891445e30

>   src/test/python/apache/aurora/client/commands/test_admin_sla.py PRE-CREATION 
>   src/test/python/apache/aurora/client/commands/util.py 11ae990c0d8e41470c6df438d37d8a2a79907a58

> 
> Diff: https://reviews.apache.org/r/18296/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python/apache/aurora/client:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message