aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suman Karumuri" <ma...@apache.org>
Subject Re: Review Request 17562: Added cluster name to page title.
Date Thu, 20 Feb 2014 21:54:10 GMT


> On Feb. 4, 2014, 8:52 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
line 231
> > <https://reviews.apache.org/r/17562/diff/3/?file=464021#file464021line231>
> >
> >     Please revert.  This is an anti-pattern, as tests can no longer alter the value.
 Ideally, the value would be plumbed through a module, but the overloaded constructor is a
compromise.

done.


> On Feb. 4, 2014, 8:52 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
line 184
> > <https://reviews.apache.org/r/17562/diff/3/?file=464021#file464021line184>
> >
> >     How about a binding for GetInfoResult instead?  This will leave us in a better
position to get rid of @ClusterName in the near future, which would be nice.

Did this in APIVersionInterceptor.


> On Feb. 4, 2014, 8:52 p.m., Bill Farner wrote:
> > src/main/thrift/org/apache/aurora/gen/api.thrift, line 456
> > <https://reviews.apache.org/r/17562/diff/3/?file=464025#file464025line456>
> >
> >     Thinking about this more, we could save the extra round-trip if the server info
is embedded in every Response.  APIVersionInterceptor already does something like this, embedding
the version number in all responses.  What do you think about that?

Done.


- Suman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17562/#review33635
-----------------------------------------------------------


On Feb. 20, 2014, 9:53 p.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17562/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2014, 9:53 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-120
>     https://issues.apache.org/jira/browse/AURORA-120
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Added getInfo API that returns page title and thrift API version.
> 
> Added a TitleController to UI to set the page title. The controller queries the getInfo
API to get the clusterName which is now included in the page title.
> 
> Deprecated getVersion API in favor of getInfo to obtain the thrift API version. 
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java ec56c649116c03ef148bac916bd6691a94685bc3

>   src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java 12113532eb062308af3c43458661c7b43b23237f

>   src/main/java/org/apache/aurora/scheduler/thrift/aop/APIVersionInterceptor.java e3e050e493e4a69e1d424d3382cb37f7ce6b7a4c

>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java c68977a7cef99a31baca2043618df304298b407e

>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 1916ff9c02216da906af4e6164212faeff37995e

>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js a0385e95c8c1fc950f507511377dcebe35f258a7

>   src/main/thrift/org/apache/aurora/gen/api.thrift 43a24969887b891339c97d4a0a055488c9188a5d

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
656e44eb51508c7ab05af8b91e9dcec216d48984 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 2254574a91c5a7bf2ddc7d8a7d31c3e4e360486d

>   src/test/java/org/apache/aurora/scheduler/thrift/aop/APIVersionInterceptorTest.java
2f0b6716fe2999c34c0351f03b6b4c1532eafee0 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/AopModuleTest.java d93ac53ec15863f2ee0e0ebc4737d8f4f8e4be9d

>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 10f5cdab16230e66ac7c9fab199e2dd2564248da

> 
> Diff: https://reviews.apache.org/r/17562/diff/
> 
> 
> Testing
> -------
> 
> gradle clean build.
> gradle run.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message