aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 18241: Reworked LogStorage to avoid unnecessary extra calls to write().
Date Wed, 19 Feb 2014 20:18:03 GMT


> On Feb. 19, 2014, 5:13 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java, line 539
> > <https://reviews.apache.org/r/18241/diff/1/?file=497164#file497164line539>
> >
> >     This is too easy to forget. Any chance this assert could be moved into log()
instead?

A marvelous suggestion, done!


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18241/#review34871
-----------------------------------------------------------


On Feb. 19, 2014, 12:55 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18241/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2014, 12:55 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-134
>     https://issues.apache.org/jira/browse/AURORA-134
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Don't unnecessarily invoke write() within LogStorage, and assert that a transaction is
open when a mutation is performed.
> 
> I'm starting to explore a refactor that further cleans this up by extracting the *Store
implementations out of LogStorage, which should simplify things by separating transaction
management from delegation.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 36e4082acceb3045ef92a5957b500e407bfc1247

>   src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java 005bad2c6b9f13e3438f3136e63fe777c6b42507

>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java f708ab3c2fa5d50b084e037f9cc0cb998935120a

> 
> Diff: https://reviews.apache.org/r/18241/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message