aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 18153: Added "sla get_job_uptime" command.
Date Tue, 18 Feb 2014 22:52:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18153/
-----------------------------------------------------------

(Updated Feb. 18, 2014, 10:52 p.m.)


Review request for Aurora, Mark Chu-Carroll and Brian Wickman.


Changes
-------

CR comments.


Bugs: AURORA-207
    https://issues.apache.org/jira/browse/AURORA-207


Repository: aurora


Description
-------

Added "sla get_job_uptime" command.

Also, changed from ValueError to ArgumentTypeError in options.py as the former is not handled
properly by argparser and no custom messages were reported.


Diffs (updated)
-----

  src/main/python/apache/aurora/client/api/sla.py b69d20818836fb6ae87b333e33008b27e013954f

  src/main/python/apache/aurora/client/cli/options.py 37f416d563b526cccf3c9cab69a5df15873db250

  src/main/python/apache/aurora/client/cli/sla.py a3973df870567052083b1d5a524438191eb6d812

  src/test/python/apache/aurora/client/api/test_sla.py 54f904c122b9e41d85dc7ad63fe3698cd0bf2923

  src/test/python/apache/aurora/client/cli/test_sla.py 703d39e4566a30900f1e9bcca5871c4a426cc6c3


Diff: https://reviews.apache.org/r/18153/diff/


Testing
-------

./build-support/jenkins/build.sh 


Thanks,

Maxim Khutornenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message