aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 17750: CronScheduler implementation based on Quartz.
Date Thu, 13 Feb 2014 23:50:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17750/
-----------------------------------------------------------

(Updated Feb. 13, 2014, 3:50 p.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
-------

Incorporate Maxim's feedback.


Bugs: AURORA-132
    https://issues.apache.org/jira/browse/AURORA-132


Repository: aurora


Description
-------

CronScheduler implementation based on Quartz.

This adds an implementation of CronScheduler using Quartz [1], allowing Aurora to execute
cron jobs without external triggering. The quartz library is Apache 2 licensed and thus including
it in Aurora complies with the ASF's third-party licensing policy.

[1] http://quartz-scheduler.org

TODO (Subsequent reviews):
  * Drop .noop package; make QuartCronModule the default
  * Delete .testing package; merge QuartzCronIT and AbstractCronIT
  * Delete thrift testing fixtures.
  * Add examples of cron jobs to examples/jobs
  * Add e2e test coverage for new examples
  * Document cron schedule syntax in config reference.
  * Create epic for reliable cron execution.


Diffs (updated)
-----

  build.gradle 4ba72c109b92d05581dbfe78194518653f20e12d 
  src/main/java/org/apache/aurora/scheduler/cron/quartz/QuartzCronModule.java PRE-CREATION

  src/main/java/org/apache/aurora/scheduler/cron/quartz/QuartzCronPredictor.java PRE-CREATION

  src/main/java/org/apache/aurora/scheduler/cron/quartz/QuartzCronScheduler.java PRE-CREATION

  src/test/java/org/apache/aurora/scheduler/cron/quartz/QuartzCronIT.java PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/cron/quartz/QuartzCronPredictorTest.java PRE-CREATION

  src/test/java/org/apache/aurora/scheduler/cron/quartz/QuartzCronSchedulerTest.java PRE-CREATION


Diff: https://reviews.apache.org/r/17750/diff/


Testing
-------

./gradlew build


Thanks,

Kevin Sweeney


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message