aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 18036: Added LeaderRedirectFilter to scheduler home page.
Date Thu, 13 Feb 2014 19:25:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18036/#review34403
-----------------------------------------------------------

Ship it!


LGTM mod redundant redundant logging

- Kevin Sweeney


On Feb. 12, 2014, 3:26 p.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18036/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2014, 3:26 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-211
>     https://issues.apache.org/jira/browse/AURORA-211
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Also added additional logging to UIRedirectFilter to expose the order in which filters
are being applied.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/http/ServletModule.java ba37e26bba4e1ad4c546e73748182deb2d5942a7

>   src/main/java/org/apache/aurora/scheduler/http/UIRedirectFilter.java b35aad8db006133ba70692e43db1f083d4950914

> 
> Diff: https://reviews.apache.org/r/18036/diff/
> 
> 
> Testing
> -------
> 
> gradle clean build
> tested on localhost, verified behavior via log statements.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message