aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 18036: Added LeaderRedirectFilter to scheduler home page.
Date Thu, 13 Feb 2014 18:55:58 GMT


> On Feb. 13, 2014, 6:29 p.m., Suman Karumuri wrote:
> > src/main/java/org/apache/aurora/scheduler/http/UIRedirectFilter.java, line 40
> > <https://reviews.apache.org/r/18036/diff/1/?file=483735#file483735line40>
> >
> >     It is not logged by the library. I prefer to have this since it provides visibility
into the logic mentioned in the previous comment.

It's logged, just at FINE.  IMHO this is noise unless we're actively debugging, in which case
you can bump the log level.


> On Feb. 13, 2014, 6:29 p.m., Suman Karumuri wrote:
> > src/main/java/org/apache/aurora/scheduler/http/ServletModule.java, line 90
> > <https://reviews.apache.org/r/18036/diff/1/?file=483734#file483734line90>
> >
> >     Line 99 takes care of the glob. 
> >     
> >     Context: The routing logic is split into 3 parts because of the special meaning
servlets assign to /. 
> >     /scheduler -> redirect to leading scheduler and into a JS asset (line 91)
> >     /scheduler/* -> redirect to leading scheduler and into servlets. (line 99
- line 84)
> >     /scheduler/ -> redirect to /scheduler (line 90)
> >     
> >     
> >     
> >

Aha, this is the line i overlooked (in registerJerseyEndpoint):

> filter(indexPath + "*").through(LeaderRedirectFilter.class);

Thanks for clearing that up.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18036/#review34387
-----------------------------------------------------------


On Feb. 12, 2014, 11:26 p.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18036/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2014, 11:26 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-211
>     https://issues.apache.org/jira/browse/AURORA-211
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Also added additional logging to UIRedirectFilter to expose the order in which filters
are being applied.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/http/ServletModule.java ba37e26bba4e1ad4c546e73748182deb2d5942a7

>   src/main/java/org/apache/aurora/scheduler/http/UIRedirectFilter.java b35aad8db006133ba70692e43db1f083d4950914

> 
> Diff: https://reviews.apache.org/r/18036/diff/
> 
> 
> Testing
> -------
> 
> gradle clean build
> tested on localhost, verified behavior via log statements.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message