aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 17955: Moving RUN_OVERLAP check into receiveJob() to prevent failure on startup.
Date Tue, 11 Feb 2014 19:40:17 GMT


> On Feb. 11, 2014, 7:27 p.m., Bill Farner wrote:
> > I don't see a test case that reproduces the bug.  Can you add that as confirmation
that schedulerActive now succeeds?

Added.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17955/#review34218
-----------------------------------------------------------


On Feb. 11, 2014, 6:58 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17955/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2014, 6:58 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-210
>     https://issues.apache.org/jira/browse/AURORA-210
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Moving RUN_OVERLAP check into receiveJob() to prevent failure on startup.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 388926c2c51c381b91ab2dcf7e4af7993d19d111

>   src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java b5d97af7454e7c4fe4b7428e2adf2c7b9ca0c1dc

>   src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
24e1bc49a446bab9ec9a8aff62438cbde89e6569 
>   src/test/java/org/apache/aurora/scheduler/state/CronJobManagerTest.java 0b565abc2187deeba466a63162de80b5e2bb5d47

> 
> Diff: https://reviews.apache.org/r/17955/diff/
> 
> 
> Testing
> -------
> 
> gradle clean build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message