aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 17785: Ignore THROTTLED tasks when looking for tasks associated with a slave.
Date Fri, 07 Feb 2014 00:05:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17785/#review33868
-----------------------------------------------------------



src/main/thrift/org/apache/aurora/gen/api.thrift
<https://reviews.apache.org/r/17785/#comment63544>

    I'm not clear on why THROTTLED is an active state - doesn't it precede PENDING?



src/test/resources/org/apache/aurora/gen/api.thrift.md5
<https://reviews.apache.org/r/17785/#comment63541>

    Looks like this might need rebasing.


- Kevin Sweeney


On Feb. 5, 2014, 10:29 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17785/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2014, 10:29 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-194
>     https://issues.apache.org/jira/browse/AURORA-194
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Since the introduction of the THROTTLED state, the Preemptor and TaskScheduler were considering
tasks in this state as active tasks on hosts within the job.  In the case of Preemptor, this
results in NullPointerException when trying to get the host of tasks in this state.  I haven't
observed the same for TaskScheduler, but i believe the same would be true when AttributeFilter
finally tries to extract the slave host.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 9d00315e4bdb4ef709ee43f250b470e38b372c7e

>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 53574814583ce7a5577e7b36af660f2c660618ca

>   src/main/java/org/apache/aurora/scheduler/base/Tasks.java 0375b9649eb1704975f32354164b13af62f7718d

>   src/main/thrift/org/apache/aurora/gen/api.thrift 77cd09ec91afc98910a867c2632c790a8e0a72ce

>   src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java bf097d7bd7f7282766163aa53e1646282b22591f

>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 4c86d8abc5ae3c5eae9f01bb085358844a87bb60

>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 10fcf08f87abb8a0e3d2750237b482ebdd3ac65d

> 
> Diff: https://reviews.apache.org/r/17785/diff/
> 
> 
> Testing
> -------
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message