aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suman Karumuri" <ma...@apache.org>
Subject Re: Review Request 17730: Now sorting roles before displaying them on home page.
Date Thu, 06 Feb 2014 19:30:16 GMT


> On Feb. 5, 2014, 8:28 p.m., Bill Farner wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, line 25
> > <https://reviews.apache.org/r/17730/diff/2/?file=469965#file469965line25>
> >
> >     JavaScript ignoramus here, but have you considered localeCompare() [1]?  This
StackOverflow answer [2] mentions it.
> >     
> >     [1] https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/String/localeCompare
> >     [2] http://stackoverflow.com/questions/51165/how-do-you-do-string-comparison-in-javascript

localeCompare doesn't sort based on ascii values in the way we want them to for example: "1,
2, 10" will be sorted as "1, 10, 2". So, using a sort function for now.


- Suman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17730/#review33719
-----------------------------------------------------------


On Feb. 5, 2014, 7:14 a.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17730/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2014, 7:14 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-190
>     https://issues.apache.org/jira/browse/AURORA-190
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Now sorting roles before displaying them on home page to match the old UI behavior.
> 
> 
> Diffs
> -----
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 9a2fdf103c7c6e4387464a05a151e3d842f90e12

>   src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 2601da9ef64ef91cbf9db9b6f12a8d2cdbb0c297

>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 0abd3e737e901f08d18c3ceb55ea2f94847cc2e1

> 
> Diff: https://reviews.apache.org/r/17730/diff/
> 
> 
> Testing
> -------
> 
> gradle clean build.
> gradle run with fake summary data.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message