aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 17749: Refactor CronScheduler interfaces to use Guava Service.
Date Wed, 05 Feb 2014 23:19:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17749/
-----------------------------------------------------------

(Updated Feb. 5, 2014, 3:19 p.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
-------

rebase to master


Bugs: AURORA-132
    https://issues.apache.org/jira/browse/AURORA-132


Repository: aurora


Description
-------

Refactor CronScheduler interfaces to use Guava Service.

Also, some methods from AbstractCronIT were dropped as they were not necessary in practice.


Diffs (updated)
-----

  src/main/java/org/apache/aurora/scheduler/cron/CronScheduler.java 34e174924a71b5acb3debc0b7911b61fab3484e0

  src/main/java/org/apache/aurora/scheduler/cron/noop/NoopCronScheduler.java bbee5efce8e4885b66ad31ec3072035d94e0d14e

  src/main/java/org/apache/aurora/scheduler/cron/testing/AbstractCronIT.java 076a7458126d4c7892289d8f5d79a78a9efc4276

  src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java 6d162862252cb23497d8a345485d515eccc781d0

  src/test/java/org/apache/aurora/scheduler/cron/noop/NoopCronIT.java 94441b8f7a66c1eabc542e56275f3b32cf536684

  src/test/java/org/apache/aurora/scheduler/state/CronJobManagerTest.java 462e64f1d6a57724ed51953149dd151081b63115


Diff: https://reviews.apache.org/r/17749/diff/


Testing
-------

./gradlew build


Thanks,

Kevin Sweeney


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message