aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 17749: Refactor CronScheduler interfaces to use Guava Service.
Date Wed, 05 Feb 2014 20:31:48 GMT


> On Feb. 5, 2014, 8:19 p.m., Bill Farner wrote:
> > I've come across Abstract[Idle]Service [1] before and didn't look hard enough at
what it offers — for those equally ignorant, this gives us call order enforcement for ~free.
 Awesome!  Let's do more of this!
> > 
> > [1] http://docs.guava-libraries.googlecode.com/git-history/release/javadoc/com/google/common/util/concurrent/Service.html

Should we be concerned about it wearing a @Beta annotation?

http://docs.guava-libraries.googlecode.com/git-history/release/javadoc/com/google/common/annotations/Beta.html:
"Signifies that a public API (public class, method or field) is subject to incompatible changes,
or even removal, in a future release. An API bearing this annotation is exempt from any compatibility
guarantees made by its containing library. Note that the presence of this annotation implies
nothing about the quality or performance of the API in question, only the fact that it is
not "API-frozen."
It is generally safe for applications to depend on beta APIs, at the cost of some extra work
during upgrades. However it is generally inadvisable for libraries (which get included on
users' CLASSPATHs, outside the library developers' control) to do so."


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17749/#review33715
-----------------------------------------------------------


On Feb. 5, 2014, 7:01 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17749/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2014, 7:01 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-132
>     https://issues.apache.org/jira/browse/AURORA-132
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Refactor CronScheduler interfaces to use Guava Service.
> 
> Also, some methods from AbstractCronIT were dropped as they were not necessary in practice.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/cron/CronScheduler.java 34e174924a71b5acb3debc0b7911b61fab3484e0

>   src/main/java/org/apache/aurora/scheduler/cron/noop/NoopCronScheduler.java bbee5efce8e4885b66ad31ec3072035d94e0d14e

>   src/main/java/org/apache/aurora/scheduler/cron/testing/AbstractCronIT.java 54b6fab83b41d603fe552456a1d6d8547930615c

>   src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java 371addf020b09a7a3d7030712d8e3cca055ef713

>   src/test/java/org/apache/aurora/scheduler/cron/noop/NoopCronIT.java 566fb47765a99f98b115cb05c08b38beff511a90

>   src/test/java/org/apache/aurora/scheduler/state/CronJobManagerTest.java 684e239bc78960617df501cc1bebffcfd21ab010

> 
> Diff: https://reviews.apache.org/r/17749/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message