aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 17712: Fixing @Override public.
Date Wed, 05 Feb 2014 01:15:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17712/#review33670
-----------------------------------------------------------

Ship it!


Ship It!

- Bill Farner


On Feb. 4, 2014, 5:51 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17712/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2014, 5:51 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Moving @Override to a separate line to comply with IntelliJ editor.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/GuiceUtils.java d77f8a90049f719573ff9c7b23d0df5ac7edcd94

>   src/main/java/org/apache/aurora/Protobufs.java 5de376b49eb2c78442c9c7b85162750d94c76bd5

>   src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 0248c95745fb49f92c1b0db08b878adf9f863a3f

>   src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java 2f84bdfb68115cda0a075c31d4e7aee76f677163

>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java d3a995996b065c8dd55829d1485b87017d047a32

>   src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 8f3f75bac53a803583f0dcf947443a9b08d3143d

>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java aa3b383a98488cc4e3c90fc932b2634458e9e5da

>   src/main/java/org/apache/aurora/scheduler/TaskVars.java 38e112a9cbed0ab14def58ecffe33cc2c8b9fd41

>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 89d1217eb8bba6b3975ade032616164303421939

>   src/main/java/org/apache/aurora/scheduler/app/Modules.java 107abbb127a5aa9bc0f0337407213496778d95d2

>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java c69a2a6c57139f0ad27b1084a24354b80d2465c6

>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 430ff03557fc7e6a7dbc851eae58882dd75e936c

>   src/main/java/org/apache/aurora/scheduler/async/HistoryPruner.java 9f77bfc74ae000275c411be04e6dd5137e269abb

>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 85bd0a63da122e7daf2f4a12938fef043136f461

>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 7bc3ebfcd3d3ababb6cc58c569b996ad1309d600

>   src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java a9ee32b6021b21d71db71b44e2eca2b984143718

>   src/main/java/org/apache/aurora/scheduler/async/TaskGroup.java a834f443a81b7cf993f6e235b1e51c4e5d0141fa

>   src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 702b0dffbc8a25ad885ccb78e4b74a1a0179fa93

>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 9c4f691c705dcbfbb0cefbdc0e1fa3f22219b5de

>   src/main/java/org/apache/aurora/scheduler/async/TaskThrottler.java fd6c1883d1973d964c57e044a7b9a4af45e2a168

>   src/main/java/org/apache/aurora/scheduler/async/TaskTimeout.java 64a1941a3b92e65c057d64edd9a823e4f89807d1

>   src/main/java/org/apache/aurora/scheduler/base/Conversions.java c77ec421d313daeca21ef978a05349527fcb7dee

>   src/main/java/org/apache/aurora/scheduler/base/JobKeys.java c9f46877efa1c86a044bb5180c2b4b0a56801343

>   src/main/java/org/apache/aurora/scheduler/base/Tasks.java 2216b2021f97ce890b25a728a189bddeba835bce

>   src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java c75241e78b54ac250ffd9a0eda7ec684fe79bc17

>   src/main/java/org/apache/aurora/scheduler/configuration/Resources.java dbad761f24d6b5b2f84433e1768e2fb7d7e2f067

>   src/main/java/org/apache/aurora/scheduler/cron/testing/AbstractCronIT.java 54b6fab83b41d603fe552456a1d6d8547930615c

>   src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java ebdede9d353ec9e8e0b44b13cc01d2c473c59f2c

>   src/main/java/org/apache/aurora/scheduler/filter/AttributeFilter.java 93ba8d7d38678dcedcbe991bd43c2e5d3bcb067f

>   src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java 8c2313c26de42949fc2456c5b00fffed1d588c64

>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 3420b0693a4251393207b7f8646354f85cf06d5c

>   src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java 6870fd8fb08848c7368763762df9a2ccb57b39c9

>   src/main/java/org/apache/aurora/scheduler/http/HttpStatsFilter.java 360a8f4279d065286486e21cd9d712ba89bb7a6e

>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java 3b6cbf5c3b352cab52b1714cd37d70bffa89dc7e

>   src/main/java/org/apache/aurora/scheduler/http/Maintenance.java fbba9f883b42b87ce039d89fdc3103dbb8636f1a

>   src/main/java/org/apache/aurora/scheduler/http/Offers.java 63a252437717533542ead48d50b26556f70b99ed

>   src/main/java/org/apache/aurora/scheduler/http/Quotas.java 899e9934f6a8af0380da0dda3b263912498796c8

>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzJob.java 1e0904fc1426b5655075b16c22538b098b3c8f60

>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java b0caca73b46fba928fb718ab45a608dad4685a2f

>   src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 60ce15cae5c00463478d57535c0b672085173ca3

>   src/main/java/org/apache/aurora/scheduler/http/Slaves.java 336b3c1b03e79c2892f2c42927a9ca350e47af66

>   src/main/java/org/apache/aurora/scheduler/http/StructDump.java e324dd63fd0dddd92ca2a94edfa873b06da62424

>   src/main/java/org/apache/aurora/scheduler/http/TransformationUtils.java 3d3b6cd68410b7103a9b33aedd87707a74e66766

>   src/main/java/org/apache/aurora/scheduler/http/Utilization.java 437f8a84fcf37270fdb221acb717d8106e9c267f

>   src/main/java/org/apache/aurora/scheduler/local/FakeDriverFactory.java 9f191e0c8657a65ba0be0aa3e66438aaefce5d30

>   src/main/java/org/apache/aurora/scheduler/local/IsolatedSchedulerModule.java 95729e1f7fcbdb1586bd751235b1cf064d56a6d6

>   src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLog.java c27cfbec7a28a9f6f99b1fd066f35f234db30d58

>   src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java 451f826e80f06c0d04ccaf27c67751eaab9ce87f

>   src/main/java/org/apache/aurora/scheduler/log/testing/FileLog.java 9f061d57b84b68898ca8a2db8fd8107a493e56c0

>   src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java 96fcbc41e463a34708850296f562b1c477628865

>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java c93e57f494f94e962139ae80b13486ccb4e44ec1

>   src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java 371addf020b09a7a3d7030712d8e3cca055ef713

>   src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java bf0a650ae55eaa66ae7ee2b8a201cb5bda38177f

>   src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java af10d44431b9bc0aec20a36a45ff74ccb1365736

>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 8ad24f9762854fa8f1ed19dfd95ca4a50640cbf3

>   src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 6fee43c80af6f125683d191ebe7fae35b1c9ca2f

>   src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java ebccc7479b0f632e585010bf9943db8f75f5ca7c

>   src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 460e7f7965e2756cd8d8be886a900ec8adc880ee

>   src/main/java/org/apache/aurora/scheduler/stats/CachedCounters.java c8d3335f6169bbd77ae9b816d71410b37a50acb6

>   src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java d2ced5340245929fb6ac939eed85d985f7e8619f

>   src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java 4f6775fc57139a29ef16256e4c578cf5f1c40069

>   src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java a556ae259940bc9d1aa5ee9026b67187ec38d36d

>   src/main/java/org/apache/aurora/scheduler/storage/ReadWriteLockManager.java 513a1595123567221f88a91cdb620088a08871c9

>   src/main/java/org/apache/aurora/scheduler/storage/Storage.java 984f5064fbe4ac74bde30f74cdf16ae22bcedf81

>   src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java aa54659f309eab41f4299fecb99dda719005c147

>   src/main/java/org/apache/aurora/scheduler/storage/backup/BackupModule.java 82e5b48d7c52293ccbfc808a587a5f4df83c37ce

>   src/main/java/org/apache/aurora/scheduler/storage/backup/Recovery.java e3c4203f78e8a2835d3c3a47b088e5334bc62dad

>   src/main/java/org/apache/aurora/scheduler/storage/backup/StorageBackup.java 22b0c2ff63cc743ec9a8d2ba58812189bd6bc06e

>   src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java 0386b0a0c33ffc116f26323d8a806ed8874a669b

>   src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java cc8f625bb65addd1eafb0c060f872f9afa98039e

>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 948fee4782c09875ccbe577c8f09483a0510bf28

>   src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 4342932cf9b20ece3f6a8a80003ca3a1e063954a

>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemJobStore.java 0419b45546de83bdc5e6306163516616581a8c37

>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 0769b68210775a77ca34afab038cbd777eb5d65e

>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 796fd756ea8cc1ec305ff5d54c741fbbdb635782

>   src/main/java/org/apache/aurora/scheduler/storage/mem/Util.java 2d9941ce04515404c052103646056564078d9de1

>   src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java 6f71fe2211ad0fec5dd0e555a591bffc5c4545fb

>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 479c2d9b3ee522d7feb125f5dea0973abb5b18b6

>   src/main/java/org/apache/aurora/scheduler/thrift/ThriftServer.java 3cc872f0c0ba81562f95beed17da02a1cdc1bdf5

>   src/main/java/org/apache/aurora/scheduler/thrift/ThriftServerLauncher.java 504ac6989b3d70766b3dd2f1ce1a3431ee420e0e

>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java 7c29094c138238ddf0d34d9f795b8aea8f17b421

>   src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java e66a885302c492b9669e9b526edd7f3c2e9f3ef7

>   src/main/java/org/apache/aurora/scheduler/thrift/aop/ThriftStatsExporterInterceptor.java
9f7e8bbd62e0f1a90404219635a8af924748c048 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/UserCapabilityInterceptor.java
8e6e52d6418f5e6809f21b7ab83e6ead0f29be19 
>   src/test/java/org/apache/aurora/GuiceUtilsTest.java 45d527ce8fbd6ec70e2d233374e09ac163d0a814

>   src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java fd4d5d5b1ad6499609cc8baa8f19cf483f1e9d49

>   src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java 282cb027dcafba8c82e00a7b055ca79ffc177678

>   src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java d6fc72e0bad32128e1fdaf52826ee41621931047

>   src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java ffc37db82b74e8d4f33c13f580b8b378c4172ee1

>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 9c0e32dcbea231f37e05f5831f794af7f0034fa2

>   src/test/java/org/apache/aurora/scheduler/async/HistoryPrunerTest.java afb7ce98d6a4336c092a8d9fa87f1be0ae36c842

>   src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java 441fbef35bd1b6404881b5590581e14b179eebcb

>   src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 3384a3a44e6a09d4745831b8dcd2e1a9e6b55e8a

>   src/test/java/org/apache/aurora/scheduler/async/RescheduleCalculatorImplTest.java c450276dfaf1f676f63ce55ec37e1d256c993164

>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 45728953294cbad099ca521fe6de5c839c5e5298

>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 34e01861bf35297c90e15593ee2e7cbfafaf265c

>   src/test/java/org/apache/aurora/scheduler/configuration/ResourcesTest.java f9f147c91be599b3a8bbd799ff750749e2d5b356

>   src/test/java/org/apache/aurora/scheduler/cron/noop/NoopCronIT.java 566fb47765a99f98b115cb05c08b38beff511a90

>   src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 2ace24a1e2e68d579fa2cfa6358d1561cf025db7

>   src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java 089db12e33d796d1b3ec66783893602b204a2b3a

>   src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java 79f09cd856be28f227fc76fb5a8e3298fb785a3a

>   src/test/java/org/apache/aurora/scheduler/state/CronJobManagerTest.java 684e239bc78960617df501cc1bebffcfd21ab010

>   src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java
f7f7632315496af085ef2f3783e7bb87fc4d23be 
>   src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java a0525e5ddb0d063b4ac498eab965cd6496928dac

>   src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java cc7d59dca749f67686c41064eeda6e62a380ffeb

>   src/test/java/org/apache/aurora/scheduler/storage/ReadWriteLockManagerTest.java 2a13f8bd5e6d8fbb322f64b3017cfef7e8d3ca4e

>   src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java f6ece9c35d5610e5522f000f87002a2fd5614484

>   src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java ad59e9cc4f1689f4097757a57a133a9b941947b4

>   src/test/java/org/apache/aurora/scheduler/storage/backup/StorageBackupTest.java 7dd96feb0ecfe5719b77097b8e8f687a26e85d3f

>   src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 1a88dd171f6dfbc3e3555ca2b1fae56cf5bd0096

>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java a651d16f3ee1298ac15b982f7cd27e947de1dcf9

>   src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java 260d96035e50ae1ee71a9c0e92d7133f8e37e32a

>   src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 0955338b0bdcf76c23ab1d3fe65eb4c2d0819a36

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
02b7a27e0a9ec5226d9d043de8bf4739fb151b09 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 644d6e87f5ed44d2705ebbcc6619a727d52c03d8

>   src/test/java/org/apache/aurora/scheduler/thrift/aop/AopModuleTest.java b510bf1222961329c4eae0a17ff0dfb274ee55a8

>   src/test/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptorTest.java
d184a529a8592cb5dc559221f28387a36c90af17 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ThriftStatsExporterInterceptorTest.java
8860bda55dbd85fda673b623b85ed259afa7d135 
> 
> Diff: https://reviews.apache.org/r/17712/diff/
> 
> 
> Testing
> -------
> 
> $ grep -iR ./src/ -e "@Override\s\S*" | wc -l
>        0
> 
> gradle clean test
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message