aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 17724: Add an exception catch to provide a better error message when distributed command runner fails
Date Tue, 04 Feb 2014 22:01:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17724/#review33647
-----------------------------------------------------------



src/main/python/apache/aurora/client/api/command_runner.py
<https://reviews.apache.org/r/17724/#comment63198>

    It's unclear why this should be an API-level check instead of a higher-level CLI check
verifying that cluster selected expresses the trait required to use the DCR. Also, this error
message isn't informative (which parameters do I need to define? where do I define them?)


- Kevin Sweeney


On Feb. 4, 2014, 1:49 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17724/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2014, 1:49 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
> 
> 
> Bugs: aurora-128
>     https://issues.apache.org/jira/browse/aurora-128
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add an exception catch to provide a better error message when distributed command runner
fails due to un-specified executor parameters in the slave configurations.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/command_runner.py c645e9556b50b332cc5a298ceee3d9188a68a727

>   src/test/python/apache/aurora/client/commands/test_run.py abcc275d57373038227d3805c16b17b967f92048

> 
> Diff: https://reviews.apache.org/r/17724/diff/
> 
> 
> Testing
> -------
> 
> Manual testing on the command line.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message