aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 17562: Added cluster name to page title.
Date Mon, 03 Feb 2014 23:18:35 GMT


> On Jan. 30, 2014, 4:56 p.m., Kevin Sweeney wrote:
> >
> 
> Suman Karumuri wrote:
>     Spoke to Bill before making these changes. We decided to use getInfo API and deprecate
getAPIVersion. The getInfo will return with the clusterName and APIVersion for now. In future
it may include other attributes and hence the flexible map.
>     
>     Thanks for the code comments. Will incorporate them once the API changes are confirmed.

For this case the magic name still doesn't make sense to me as it's defined in api.thrift.
Why not just make it a field and maintain type-safety?


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17562/#review33266
-----------------------------------------------------------


On Jan. 30, 2014, 2:27 p.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17562/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2014, 2:27 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-120
>     https://issues.apache.org/jira/browse/AURORA-120
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Added getInfo API that returns page title and thrift API version.
> 
> Added a TitleController to UI to set the page title. The controller queries the getInfo
API to get the clusterName which is now included in the page title.
> 
> Deprecated getVersion API in favor of getInfo to obtain the thrift API version. 
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 822b8b9e3348677ff2f45da2f76ae9a7a96a41b6

>   src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 2601da9ef64ef91cbf9db9b6f12a8d2cdbb0c297

>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 0abd3e737e901f08d18c3ceb55ea2f94847cc2e1

>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js a0385e95c8c1fc950f507511377dcebe35f258a7

>   src/main/thrift/org/apache/aurora/gen/api.thrift 94569f9abfb56c50e67e09cc018484463f9de427

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
02b7a27e0a9ec5226d9d043de8bf4739fb151b09 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 644d6e87f5ed44d2705ebbcc6619a727d52c03d8

>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 62fc8045f6a5fda234df73452685bd04e3142aaf

>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 e88d29732ee8652ede6c7ee13513122086385646

> 
> Diff: https://reviews.apache.org/r/17562/diff/
> 
> 
> Testing
> -------
> 
> gradle clean build.
> gradle run.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message