aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 17666: Adding DRAINING state into api.thrift.
Date Mon, 03 Feb 2014 20:44:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17666/
-----------------------------------------------------------

(Updated Feb. 3, 2014, 8:44 p.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
-------

CR comments addressed.


Bugs: AURORA-82
    https://issues.apache.org/jira/browse/AURORA-82


Repository: aurora


Description (updated)
-------

Splitting this work into 3 steps to ensure schema compatibility between releases.
Step1: Adding DRAINING state into api.thrift and rewriting DRAINING to RESTARTING in StorageBackfill.

To come:
Step2: Implement support for DRAINING in state machine.


Diffs (updated)
-----

  src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java 3ce5bd38482c40279694fd068d0e4df825be40df

  src/main/thrift/org/apache/aurora/gen/api.thrift 94569f9abfb56c50e67e09cc018484463f9de427

  src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java 153f82c1136daac69653f0083250bb3343b1148e

  src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java PRE-CREATION

  src/test/resources/org/apache/aurora/gen/api.thrift.md5 e88d29732ee8652ede6c7ee13513122086385646


Diff: https://reviews.apache.org/r/17666/diff/


Testing
-------

gradle clean build


Thanks,

Maxim Khutornenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message