aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 17637: AURORA-88: get_quota -h lists --cluster as deprecated
Date Mon, 03 Feb 2014 15:56:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17637/#review33428
-----------------------------------------------------------



src/main/python/apache/aurora/client/options.py
<https://reviews.apache.org/r/17637/#comment62870>

    Thanks for looking into it Dan! Please, include markcc into reviewers line as he is in
charge of aurora client v2.
    
    In general, we are trying to deprecate --cluster option in favor of a more flexible job
path approach. I think "cluster/role" is what we want to have here.


- Maxim Khutornenko


On Feb. 2, 2014, 2:07 p.m., Dan Norris wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17637/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2014, 2:07 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: aurora-88
>     https://issues.apache.org/jira/browse/aurora-88
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-88: get_quota -h lists --cluster as deprecated
> 
> Replaces CLUSTER_INVOKE_OPTION with a new CLUSTER_NAME_OPTION so that
> get_quota -h shows the correct help dialog.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/commands/core.py 8dc4917df7e0d699ee144b4e8fbede6ac05157c2

>   src/main/python/apache/aurora/client/options.py 4e53b0765375989bb80ffd02e0ef2b08af1eea50

> 
> Diff: https://reviews.apache.org/r/17637/diff/
> 
> 
> Testing
> -------
> 
> Tests pass locally and running aurora_client.pex get_quota -h shows the updated text
for the --cluster option.
> 
> 
> Thanks,
> 
> Dan Norris
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message