Return-Path: 
 <reviews-return-441-apmail-aurora-reviews-archive=aurora.apache.org@aurora.incubator.apache.org>
X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org
Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 4AC7D10322
	for <apmail-aurora-reviews-archive@minotaur.apache.org>;
 Fri, 31 Jan 2014 19:35:00 +0000 (UTC)
Received: (qmail 37093 invoked by uid 500); 31 Jan 2014 19:34:59 -0000
Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org
Received: (qmail 37065 invoked by uid 500); 31 Jan 2014 19:34:59 -0000
Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:reviews-help@aurora.incubator.apache.org>
List-Unsubscribe: <mailto:reviews-unsubscribe@aurora.incubator.apache.org>
List-Post: <mailto:reviews@aurora.incubator.apache.org>
List-Id: <reviews.aurora.incubator.apache.org>
Reply-To: reviews@aurora.incubator.apache.org
Delivered-To: mailing list reviews@aurora.incubator.apache.org
Received: (qmail 37057 invoked by uid 99); 31 Jan 2014 19:34:59 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 31 Jan 2014 19:34:59 +0000
X-ASF-Spam-Status: No, hits=-1998.3 required=5.0
	tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3)
    by apache.org (qpsmtpd/0.29) with SMTP; Fri, 31 Jan 2014 19:34:56 +0000
Received: (qmail 36933 invoked by uid 99); 31 Jan 2014 19:34:34 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 31 Jan 2014 19:34:34 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 18C741D4718;
	Fri, 31 Jan 2014 19:34:33 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============2888997048738540914=="
MIME-Version: 1.0
Subject: Re: Review Request 17581: AURORA-108: make set_quota in aurora_admin
 require
 explicit units
From: "Dan Norris" <protochron@gmail.com>
To: "Mark Chu-Carroll" <mchucarroll@twopensource.com>
Cc: "Bill Farner" <wfarner@apache.org>, "Dan Norris" <protochron@gmail.com>,
 "Aurora" <reviews@aurora.incubator.apache.org>
Date: Fri, 31 Jan 2014 19:34:33 -0000
Message-ID: <20140131193433.22330.61065@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org
Auto-Submitted: auto-generated
Sender: "Dan Norris" <noreply@reviews.apache.org>
X-ReviewGroup: Aurora
X-ReviewRequest-URL: https://reviews.apache.org/r/17581/
X-Sender: "Dan Norris" <noreply@reviews.apache.org>
References: <20140131184608.21445.19914@reviews.apache.org>
In-Reply-To: <20140131184608.21445.19914@reviews.apache.org>
Reply-To: "Dan Norris" <protochron@gmail.com>
X-ReviewRequest-Repository: aurora
X-Virus-Checked: Checked by ClamAV on apache.org

--===============2888997048738540914==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17581/
-----------------------------------------------------------

(Updated Jan. 31, 2014, 7:34 p.m.)


Review request for Aurora and Mark Chu-Carroll.


Changes
-------

Updated patch to use parse_data from twitter.common.


Bugs: AURORA-136
    https://issues.apache.org/jira/browse/AURORA-136


Repository: aurora


Description
-------

AURORA-108: make set_quota in aurora_admin require explicit units

set_quota now requies a specific unit (M or G) as input.

This means that arguments to set_quote should resemble the following:
    set_quota(<cluster>, <role>, <cpu>, '50M', '20G')
    set_quota(<cluster>, <role>, <cpu>, '50G', '20G')


Diffs (updated)
-----

  src/main/python/apache/aurora/client/api/__init__.py f82900371f8e7566da07beeef4ff0622105c64d6 
  src/main/python/apache/aurora/client/commands/admin.py 6d191f406a284c60326a49aed32914c81522d4d2 

Diff: https://reviews.apache.org/r/17581/diff/


Testing
-------

Passes local tests. I could not find a test that tests the quota for the cli client so this patch does not contain an dedicated test case.


Thanks,

Dan Norris


--===============2888997048738540914==--