Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5EB80100D1 for ; Wed, 29 Jan 2014 00:29:37 +0000 (UTC) Received: (qmail 72178 invoked by uid 500); 29 Jan 2014 00:29:35 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 72140 invoked by uid 500); 29 Jan 2014 00:29:35 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 72131 invoked by uid 99); 29 Jan 2014 00:29:35 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Jan 2014 00:29:35 +0000 X-ASF-Spam-Status: No, hits=-1998.3 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 29 Jan 2014 00:29:32 +0000 Received: (qmail 72072 invoked by uid 99); 29 Jan 2014 00:29:10 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Jan 2014 00:29:10 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 209DA1D46A7; Wed, 29 Jan 2014 00:29:09 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8237649655543337565==" MIME-Version: 1.0 Subject: Re: Review Request 17430: Bug fix: Return job count instead of task count on GetRoleSummary() call. From: "Kevin Sweeney" To: "Bill Farner" , "Kevin Sweeney" Cc: "Aurora" , "Suman Karumuri" Date: Wed, 29 Jan 2014 00:29:09 -0000 Message-ID: <20140129002909.6388.98532@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Kevin Sweeney" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/17430/ X-Sender: "Kevin Sweeney" References: <20140128221802.6810.24951@reviews.apache.org> In-Reply-To: <20140128221802.6810.24951@reviews.apache.org> Reply-To: "Kevin Sweeney" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============8237649655543337565== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17430/#review33076 ----------------------------------------------------------- Ship it! Ship It! - Kevin Sweeney On Jan. 28, 2014, 2:17 p.m., Suman Karumuri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17430/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2014, 2:17 p.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Bugs: AURORA-116 > https://issues.apache.org/jira/browse/AURORA-116 > > > Repository: aurora > > > Description > ------- > > Updated test cases to catch this bug. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java cf9099f307efa23ca34634e3512d9cdbebfa82f2 > src/main/thrift/org/apache/aurora/gen/api.thrift 74010379baa2e47cefc228943f766c7b3a8b0d97 > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 6cefdfad469a9b69a5291ad46be1df14b443472e > src/test/resources/org/apache/aurora/gen/api.thrift.md5 42fdca2759f15d007bee058485c237268c57597a > > Diff: https://reviews.apache.org/r/17430/diff/ > > > Testing > ------- > > gradle clean build > gradle run - tested in local UI. > > > Thanks, > > Suman Karumuri > > --===============8237649655543337565==--