Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C808910BE7 for ; Tue, 21 Jan 2014 23:40:33 +0000 (UTC) Received: (qmail 2241 invoked by uid 500); 21 Jan 2014 23:40:33 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 2217 invoked by uid 500); 21 Jan 2014 23:40:33 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 2209 invoked by uid 99); 21 Jan 2014 23:40:33 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Jan 2014 23:40:33 +0000 X-ASF-Spam-Status: No, hits=-1998.3 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 21 Jan 2014 23:40:31 +0000 Received: (qmail 588 invoked by uid 99); 21 Jan 2014 23:40:10 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Jan 2014 23:40:10 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DB1791D4534; Tue, 21 Jan 2014 23:40:09 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1696712560181505805==" MIME-Version: 1.0 Subject: Re: Review Request 17014: Show an error message in the UI when scheduler returns an invalid response. From: "Kevin Sweeney" To: "Bill Farner" , "Kevin Sweeney" Cc: "Aurora" , "Suman Karumuri" Date: Tue, 21 Jan 2014 23:40:09 -0000 Message-ID: <20140121234009.28235.68644@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Kevin Sweeney" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/17014/ X-Sender: "Kevin Sweeney" References: <20140121212805.28235.20922@reviews.apache.org> In-Reply-To: <20140121212805.28235.20922@reviews.apache.org> Reply-To: "Kevin Sweeney" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============1696712560181505805== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17014/#review32444 ----------------------------------------------------------- src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js Could this be set to the actual error message? This implementation seems to swallow it. - Kevin Sweeney On Jan. 21, 2014, 1:28 p.m., Suman Karumuri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17014/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2014, 1:28 p.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Bugs: AURORA-18 > https://issues.apache.org/jira/browse/AURORA-18 > > > Repository: aurora > > > Description > ------- > > Show an error message when a call to the thrift end point returns an invalid response. > > > Diffs > ----- > > src/main/resources/org/apache/aurora/scheduler/http/ui/index.html c6706c1d2b395966921c68a83acdef06c1bb8c53 > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js f1333f148970b5bc94f3ad77d077e90ebc09cf32 > src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 16f22a700abb7ba51559e3cfbb04d9218bf4f98a > > Diff: https://reviews.apache.org/r/17014/diff/ > > > Testing > ------- > > gradle clean build. > > Tested with local scheduler. Scheduler shows an error message (ex: when storage is not ready) > > > Thanks, > > Suman Karumuri > > --===============1696712560181505805==--