Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============2821224234642088951=="
MIME-Version: 1.0
Subject: Re: Review Request 16743: Use a separate thread for Driver.join() to
 avoid
 stalling the executor service.
From: "Bill Farner" <wfarner@apache.org>
To: "Maxim Khutornenko" <maxim@apache.org>,
 "Mark Chu-Carroll" <mchucarroll@twopensource.com>
Cc: "Bill Farner" <wfarner@apache.org>,
 "Aurora" <reviews@aurora.incubator.apache.org>
Date: Thu, 09 Jan 2014 00:26:17 -0000
Message-ID: <20140109002617.11587.30036@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Bill Farner" <noreply@reviews.apache.org>
References: <20140108231556.11587.22087@reviews.apache.org>
In-Reply-To: <20140108231556.11587.22087@reviews.apache.org>
Reply-To: "Bill Farner" <wfarner@apache.org>

--===============2821224234642088951==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16743/#review31416
-----------------------------------------------------------


Thanks, folks.  This is now on master.

- Bill Farner


On Jan. 8, 2014, 11:15 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16743/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2014, 11:15 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-25
>     https://issues.apache.org/jira/browse/AURORA-25
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Use a separate thread for Driver.join() to avoid stalling the executor service.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 3ab73e65c8aa6028fea62b4f04732aeb55ffeced 
>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java a5ce840590fde928817f7597af192b562b5dba04 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 106fbb3e6e09518df3b2d687a0a85e4ecae0e72f 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 2e682a142bda159832d69d84e4f3e6bfd555b92b 
> 
> Diff: https://reviews.apache.org/r/16743/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> The unit test changes were made to reproduce AURORA-25 (and happen to be more true to real-world behavior).
> 
> Also, running the scheduler locally prior to this change would silently reproduce this issue.  The result would be lack of a log line like this:
> 
> I0108 23:08:17.960 THREAD22 com.twitter.common.zookeeper.ServerSetImpl$ServerSetWatcher.logChange: server set /twitter/service/mesos/local/scheduler change: from 0 members to 1
> 	joined:
> 		ServiceInstance(serviceEndpoint:Endpoint(host:192.168.33.1, port:8082), additionalEndpoints:{http=Endpoint(host:192.168.33.1, port:8081)}, status:ALIVE)
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


--===============2821224234642088951==--