aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Norris" <>
Subject Re: Review Request 17581: AURORA-108: make set_quota in aurora_admin require explicit units
Date Fri, 31 Jan 2014 19:34:33 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 31, 2014, 7:34 p.m.)

Review request for Aurora and Mark Chu-Carroll.


Updated patch to use parse_data from twitter.common.

Bugs: AURORA-136

Repository: aurora


AURORA-108: make set_quota in aurora_admin require explicit units

set_quota now requies a specific unit (M or G) as input.

This means that arguments to set_quote should resemble the following:
    set_quota(<cluster>, <role>, <cpu>, '50M', '20G')
    set_quota(<cluster>, <role>, <cpu>, '50G', '20G')

Diffs (updated)

  src/main/python/apache/aurora/client/api/ f82900371f8e7566da07beeef4ff0622105c64d6

  src/main/python/apache/aurora/client/commands/ 6d191f406a284c60326a49aed32914c81522d4d2



Passes local tests. I could not find a test that tests the quota for the cli client so this
patch does not contain an dedicated test case.


Dan Norris

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message