aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suman Karumuri" <ma...@apache.org>
Subject Re: Review Request 17430: Bug fix: Return job count instead of task count on GetRoleSummary() call.
Date Tue, 28 Jan 2014 20:51:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17430/
-----------------------------------------------------------

(Updated Jan. 28, 2014, 8:51 p.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
-------

Addressed code review feedback.

Fixed the thrift response to use a set instead of a list, since I found an ordering bug while
running the test.


Bugs: AURORA-116
    https://issues.apache.org/jira/browse/AURORA-116


Repository: aurora


Description
-------

Updated test cases to catch this bug.


Diffs (updated)
-----

  src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java cf9099f307efa23ca34634e3512d9cdbebfa82f2

  src/main/thrift/org/apache/aurora/gen/api.thrift 74010379baa2e47cefc228943f766c7b3a8b0d97

  src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 6cefdfad469a9b69a5291ad46be1df14b443472e

  src/test/resources/org/apache/aurora/gen/api.thrift.md5 42fdca2759f15d007bee058485c237268c57597a


Diff: https://reviews.apache.org/r/17430/diff/


Testing
-------

gradle clean build
gradle run - tested in local UI.


Thanks,

Suman Karumuri


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message