aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 17131: Improve test coverage for CronJobManager.
Date Wed, 22 Jan 2014 19:02:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17131/
-----------------------------------------------------------

(Updated Jan. 22, 2014, 7:02 p.m.)


Review request for Aurora, Suman Karumuri and Maxim Khutornenko.


Changes
-------

CronJob -> SanitizedCronJob.


Bugs: AURORA-62
    https://issues.apache.org/jira/browse/AURORA-62


Repository: aurora


Description
-------

This raises instruction test coverage from 76% to 95%, and branch coverage from 75% to 96%.

There are only two things not currently covered:
- Handling when catching InterruptedException (this only logs)
- Handling unknown CollisionPolicy (only logs)


Diffs (updated)
-----

  src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java 5a56a701a6a355f9de3f05fbb95013b96b06b171

  src/test/java/org/apache/aurora/scheduler/state/CronJobManagerTest.java e9886cdb279cc42a961d6c964e2cfae3c4c13f61


Diff: https://reviews.apache.org/r/17131/diff/


Testing
-------

./gradlew build


Thanks,

Bill Farner


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message