aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Boulle" <...@twopensource.com>
Subject Re: Review Request 17153: Implement "restart" command for client v2.
Date Wed, 22 Jan 2014 02:16:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17153/#review32454
-----------------------------------------------------------


Mark - want to put some time in my calendar tomorrow to sit down together and go through all
the outstanding reviews to get them merged? The patches are in a bit of a confusing state,
every time I look at a review it seems like it's reverting something inadvertently :-(


src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/17153/#comment61315>

    hm..... missing merge?



src/main/python/apache/aurora/client/cli/options.py
<https://reviews.apache.org/r/17153/#comment61316>

    s/operate/operated/


- Jonathan Boulle


On Jan. 21, 2014, 10:03 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17153/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2014, 10:03 p.m.)
> 
> 
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
> 
> 
> Bugs: aurora-54
>     https://issues.apache.org/jira/browse/aurora-54
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implement "restart" command for client v2.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/context.py 78e54a2233b825ab057a1fb2397c91b50ad1aec0

>   src/main/python/apache/aurora/client/cli/jobs.py f60d7e9fa5367f43829957e3485e43e76c84bf48

>   src/main/python/apache/aurora/client/cli/options.py 1b7155409505b46451df072edd196dd7e4c88f1c

>   src/test/python/apache/aurora/client/cli/BUILD f9ebe0cf626a040aa67654faea07b8902e558282

>   src/test/python/apache/aurora/client/cli/test_restart.py PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/test_update.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17153/diff/
> 
> 
> Testing
> -------
> 
> [sun-wukong aurora (restart)]$ ./pants src/test/python/apache/aurora/client/cli:all
> Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> ====================================== test session starts ======================================
> platform darwin -- Python 2.7.2 -- pytest-2.5.1
> collected 23 items
> 
> src/test/python/apache/aurora/client/cli/test_create.py ....
> src/test/python/apache/aurora/client/cli/test_kill.py .....
> src/test/python/apache/aurora/client/cli/test_status.py .....
> src/test/python/apache/aurora/client/cli/test_update.py ...
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> 
> =================================== 23 passed in 1.39 seconds ===================================
> src.test.python.apache.aurora.client.cli.job                                    .....
  SUCCESS
> [sun-wukong aurora (restart)]$
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message