aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 17131: Improve test coverage for CronJobManager.
Date Tue, 21 Jan 2014 16:03:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17131/#review32376
-----------------------------------------------------------

Ship it!



src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java
<https://reviews.apache.org/r/17131/#comment61173>

    +1 for inlining it.


- Maxim Khutornenko


On Jan. 20, 2014, 9:01 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17131/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2014, 9:01 p.m.)
> 
> 
> Review request for Aurora, Suman Karumuri and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-62
>     https://issues.apache.org/jira/browse/AURORA-62
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This raises instruction test coverage from 76% to 95%, and branch coverage from 75% to
96%.
> 
> There are only two things not currently covered:
> - Handling when catching InterruptedException (this only logs)
> - Handling unknown CollisionPolicy (only logs)
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java 5a56a701a6a355f9de3f05fbb95013b96b06b171

>   src/test/java/org/apache/aurora/scheduler/state/CronJobManagerTest.java e9886cdb279cc42a961d6c964e2cfae3c4c13f61

> 
> Diff: https://reviews.apache.org/r/17131/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message