aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Chu-Carroll" <mchucarr...@twopensource.com>
Subject Re: Review Request 17051: Add clientv2 implementations of update and list jobs.
Date Fri, 17 Jan 2014 18:56:14 GMT


> On Jan. 17, 2014, 1:28 p.m., Brian Wickman wrote:
> > src/main/python/apache/aurora/client/cli/options.py, line 29
> > <https://reviews.apache.org/r/17051/diff/1/?file=427121#file427121line29>
> >
> >     isn't there already parse_shards_into?

D'oh. I meant to fix that before sending it for review; I got so concerned about the other
merge grief after the whole scheduler renaming fiasco that I forgot about it.


> On Jan. 17, 2014, 1:28 p.m., Brian Wickman wrote:
> > src/test/python/apache/aurora/client/cli/BUILD, line 17
> > <https://reviews.apache.org/r/17051/diff/1/?file=427123#file427123line17>
> >
> >     you can always glob('test_*.py') here if you want.

Yeah, I know. But while I'm working on this, I'm frequently temporarily breaking things. It's
useful to be able to just edit the BUILD file to get rid of the tests that I expect to fail
while I'm making a change. Once this stabilizes, I'll switch to the glob.


> On Jan. 17, 2014, 1:28 p.m., Brian Wickman wrote:
> > src/test/python/apache/aurora/client/cli/test_update.py, lines 33-35
> > <https://reviews.apache.org/r/17051/diff/1/?file=427124#file427124line33>
> >
> >     why is this not gen.apache.aurora.constants ACTIVE_STATES?  a similar test broke
when bill added the THROTTLED state

I don't remember. I think there was a reason when I wrote the test... should have documented.
I'll switch it now.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17051/#review32163
-----------------------------------------------------------


On Jan. 17, 2014, 11:49 a.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17051/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2014, 11:49 a.m.)
> 
> 
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
> 
> 
> Bugs: aurora-53
>     https://issues.apache.org/jira/browse/aurora-53
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add clientv2 implementations of update and list jobs.
> 
> (This was originally planned to also include cancel_update and
> restart, but after testing problems led to splitting out AURORA-42,
> and merges with restart failed, I decided to submit these two,
> and put the others in a subsequent change.)
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/context.py be156bb52dd48e8e5a0df3ddfb0aef1a815d538e

>   src/main/python/apache/aurora/client/cli/jobs.py c519e3c1a4dc055ae1a77d29ca5ba2e6464cacf0

>   src/main/python/apache/aurora/client/cli/options.py 0aaf8801950b18be2f00fb1a1f9d8a5a853a1c42

>   src/main/python/apache/aurora/client/commands/core.py edc57b20f37e6c3d4f13b357b922b9b69091050d

>   src/test/python/apache/aurora/client/cli/BUILD 97b074488c569c1c92e2bfd69f09ffbd3a827d49

>   src/test/python/apache/aurora/client/cli/test_update.py PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/util.py 2985865264a7fd9dd8f59182a4df9e335e210f84

> 
> Diff: https://reviews.apache.org/r/17051/diff/
> 
> 
> Testing
> -------
> 
> Unit tests all pass; new tests added for the new update command.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message