aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suman Karumuri" <ma...@apache.org>
Subject Re: Review Request 16995: Only make the SchedulerDriver available after registered() has been called.
Date Fri, 17 Jan 2014 00:37:29 GMT


> On Jan. 16, 2014, 11:41 p.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/Driver.java, lines 148-149
> > <https://reviews.apache.org/r/16995/diff/1/?file=425119#file425119line148>
> >
> >     There's a (very small window) check-then-act race here. Should this be synchronized
or use checkState(driverRef.compareAndSet(null, driver))?

+1 for using checkState(driverRef.compareAndSet(null, driver))


- Suman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16995/#review32096
-----------------------------------------------------------


On Jan. 16, 2014, 11 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16995/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2014, 11 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Suman Karumuri.
> 
> 
> Bugs: AURORA-45
>     https://issues.apache.org/jira/browse/AURORA-45
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> I've also removed some functions from the Driver interface, since they should be used
exclusively by SchedulerLifecycle.
> 
> No test cases were added because SchedulerLifecycleTest#testDefeatedBeforeRegistered()
triggered the issue once expectations were altered with the desired new behavior.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/Driver.java 5339069a0b932b4f16867335c4b5ee111169742b

>   src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 247e94065a7f6d9170c2e21ae91b4078c76f0112

>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 43f0c4e6b8a75db029e8c61495326a6ab80febb6

>   src/test/java/org/apache/aurora/scheduler/DriverTest.java c3aa69c1e1bf3e301806fe20fb4d8686ca941e37

>   src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java da7a1678d734ddc7b513b1d0797cb097fa2ee537

> 
> Diff: https://reviews.apache.org/r/16995/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message