aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 16874: Deprecate CronCollisionPolicy.RUN_OVERLAP.
Date Wed, 15 Jan 2014 20:03:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16874/#review31910
-----------------------------------------------------------


Thinking out loud — would it be better to just outright reject RUN_OVERLAP?  This certainly
has an immediate effect for anyone using it, but at least it won't go unnoticed.  I don't
feel _too_ strongly either way, FWIW.

- Bill Farner


On Jan. 14, 2014, 11:32 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16874/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2014, 11:32 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-38
>     https://issues.apache.org/jira/browse/AURORA-38
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Deprecate CronCollisionPolicy.RUN_OVERLAP.
> 
> To prevent cluster starvation, the scheduler now ignores new cron jobs
> with RUN_OVERLAP and behaves like CANCEL_NEW for existing ones. The
> choice of CANCEL_NEW was arbitrary but IMO fits with the mental
> preemption model of Aurora better (you're never guaranteed that a new
> instance will schedule but Aurora doesn't tend to kill existing
> instances outside of an established preemption routine).
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java f7890186a0fc10ee9fcceff63bbb671dc41eb3be

>   src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java b772712b8b3c1e7eb53bfbf55e9d2fc4ee9d5ad9

>   src/main/thrift/org/apache/aurora/gen/api.thrift 33c70df70713427c186081dd1815dd4e8fe14fa8

>   src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
c9ffc70c537ad2b4e72fa6aaaf39ab4478a230af 
>   src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java 720d0c86d8b112bf92196cbb81ece44476534654

>   src/test/java/org/apache/aurora/scheduler/state/CronJobManagerTest.java c67912365e1ca40a6d0d57cce6dc169306d17f10

> 
> Diff: https://reviews.apache.org/r/16874/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message