aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suman Karumuri" <ma...@apache.org>
Subject Re: Review Request 16740: When rescheduling a task, send it to the THROTTLED state if it has been penalized for flapping.
Date Tue, 14 Jan 2014 20:03:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16740/#review31785
-----------------------------------------------------------

Ship it!


Ship It!

- Suman Karumuri


On Jan. 13, 2014, 11:54 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16740/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2014, 11:54 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Suman Karumuri, and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-23
>     https://issues.apache.org/jira/browse/AURORA-23
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> When rescheduling a task, send it to the THROTTLED state if it has been penalized for
flapping.
> 
> Changes specific to the issue:
> - Introduced TaskThrottler[Test], which initiates THROTTLED->PENDING transitions
> - RescheduleCalculator methods return a delay rather than a timestamp, for inclusion
in transition audit messages
> - Removed StorageBackfillTest, which was only testing rewriting the THROTTLED state for
backwards compatibility
> 
> There's also a fair amount of code cleanup going on in this review:
> 
> - A unit test for RescheduleCalculator was pulled out of TaskSchedulerTest test cases
(per TODO)
> - Introduced Tasks.getLatestEvent, which was independently implemented in several places
> - Removed unused TaskRescheduled pubsub event
> - Removed REVERSE_CHRON_COMPARATOR from SchedulerzJob, which is === Tasks.LATEST_ACTIVITY.reverse()
> - Added a batch changeState helper function in BaseSchedulerCoreImplTest for more concise
calling code
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 6be658d7e90f59c63e6895df3917a7869b4045cc

>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 0afbef950151e8cd1e865d93b53ffa4ad92f8eeb

>   src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java 0265bf941814ab4b6425ecf4dc9672dfa361e94f

>   src/main/java/org/apache/aurora/scheduler/async/TaskGroup.java 1a008745ac8807edd894269722fa2ae989b70bbd

>   src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java b50c625092812f84b3f0a9e790bbe7011a60c1ce

>   src/main/java/org/apache/aurora/scheduler/async/TaskThrottler.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/base/Tasks.java 569e8c32643acdce35062d283c7411e026b86c8d

>   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 59e18eaefc024b7493b4b2aa3757b831022236f3

>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzJob.java 07a648fad0ea55bdb126b6d8d2ed15754430f556

>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java cef0ff28bb0c0e08c5efaa1ed326f66bc9ffa5d9

>   src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java b6dd5379481423051b9243ad0dbfae7b057173f4

>   src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java d0f88e5b16b8e4af299cd1d19f806b1a6c53eab4

>   src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java 69374ca706ff7ab6267c37021612cefb74df0bc0

>   src/main/thrift/org/apache/aurora/gen/api.thrift 33c70df70713427c186081dd1815dd4e8fe14fa8

>   src/test/java/org/apache/aurora/scheduler/async/RescheduleCalculatorImplTest.java PRE-CREATION

>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 9698f283c04197039d22cd38220a1dda448bdcf7

>   src/test/java/org/apache/aurora/scheduler/async/TaskThrottlerTest.java PRE-CREATION

>   src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java 720d0c86d8b112bf92196cbb81ece44476534654

>   src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java b17b983f66ce0ac1ef90b716a28813a505322b17

>   src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java e89e60afc107b299d572a07140d010040b2c7545

>   src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 724188bfa037caccaf91cf57d82de1777ab5de8e

> 
> Diff: https://reviews.apache.org/r/16740/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message