aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Wickman" <wick...@gmail.com>
Subject Re: Review Request 16423: client v2: added implementations of job diff, job inspect.
Date Mon, 13 Jan 2014 17:46:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16423/#review31620
-----------------------------------------------------------

Ship it!



src/main/python/apache/aurora/client/cli/context.py
<https://reviews.apache.org/r/16423/#comment60243>

    this can be 'for component in key' since namedtuples and AuroraJobKeys are iterable.


- Brian Wickman


On Jan. 13, 2014, 3:02 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16423/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2014, 3:02 p.m.)
> 
> 
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implemented client v2 versions of the diff and inspect verbs.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 2c08cf985a3ad9126a544596f895540524af865c

>   src/main/python/apache/aurora/client/cli/context.py c50f1a15847f5374a30d6bc93915123d8471e4aa

>   src/main/python/apache/aurora/client/cli/jobs.py b789361313e279ac8398a92a46ec724c09fb4513

>   src/main/python/apache/aurora/client/cli/options.py 80fabb93945f38011b1e9c64ed20f8035ec146fa

>   src/main/python/apache/aurora/client/options.py af56351eed21805f09bfe50cb91745d58b665627

>   src/main/python/twitter/aurora/client/cli/BUILD PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/BUILD 9528eed70e76431f720c4a26651ae0729903288c

>   src/test/python/apache/aurora/client/cli/test_create.py df2386d3e1372d5dc3eb55f8e3a0f471a9b3ab54

>   src/test/python/apache/aurora/client/cli/test_kill.py 75fb6b6a66ce018015073fc0ee04bf6e9a5c0773

>   src/test/python/apache/aurora/client/cli/test_status.py PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/util.py c6d38304fb8ac89b9a175d8c20438a8831f784df

>   src/test/python/twitter/aurora/client/cli/BUILD PRE-CREATION 
>   src/test/python/twitter/aurora/client/cli/test_diff.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16423/diff/
> 
> 
> Testing
> -------
> 
> Added new unit tests for "diff"; inspect doesn't do any API calls that aren't already
tested.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message