aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 16767: Begin cleanup of StateManager interface by removing state change via Query.
Date Fri, 10 Jan 2014 21:01:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16767/#review31538
-----------------------------------------------------------

Ship it!



src/main/java/org/apache/aurora/scheduler/state/StateManager.java
<https://reviews.apache.org/r/16767/#comment60061>

    A bit of explanation of what "cas" stand for would not hurt here as it's not obvious from
the description or implementation why it's used.



src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java
<https://reviews.apache.org/r/16767/#comment60062>

    Unfinished TODO comment?



src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java
<https://reviews.apache.org/r/16767/#comment60064>

    Would task ever be null here? 



src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java
<https://reviews.apache.org/r/16767/#comment60067>

    Nice!


- Maxim Khutornenko


On Jan. 9, 2014, 10:40 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16767/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2014, 10:40 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Bugs: AURORA-27
>     https://issues.apache.org/jira/browse/AURORA-27
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> State changes via a broad query is a rarely-used feature, and probably usually not a
good idea.  The query-based API was useful because it sometimes saves code at the call site,
but the big downside is that it makes it more difficult for StateManager to perform course-correcting
operations.  The test case added to StateManagerImplTest illustrates a now-fixed regression
that could contribute to state drift between the scheduler and the outside world.
> 
> Additionally, this API change is me working my way towards removing a bunch of the (hopefully-unnecessary)
complexity that exists in StateManagerImpl and TaskStateMachine.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 7e180ac1bb2cf2f7b07f25441614027e15b75c8b

>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 96c76ba1b72853ae16399813bfac6c8db5aaf1a9

>   src/main/java/org/apache/aurora/scheduler/async/TaskTimeout.java 9f14a995e6e60098659542624b9ee951eea912ed

>   src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 3dd2271004a26a597989574527459e887fba44e4

>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java b89d9905398feaaf7f1329409d8c27edc9f0d49a

>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 1d450f2d2d8e747878b67bccbf3fd7d018a52d20

>   src/main/java/org/apache/aurora/scheduler/state/StateManager.java 045165da2fdec7f2d4b24402901752d1c6b3976a

>   src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java b6dd5379481423051b9243ad0dbfae7b057173f4

>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java c1a11bdb91c5e764864324d26248d1783af8048b

>   src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java bba1b722ae9c308e3767da2c396b86d05531c65a

>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 9698f283c04197039d22cd38220a1dda448bdcf7

>   src/test/java/org/apache/aurora/scheduler/async/TaskTimeoutTest.java 023905b6e6fe0a7ff095a2b37b9f73f9801a8123

>   src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java 720d0c86d8b112bf92196cbb81ece44476534654

>   src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java
c0addd6670009b1ed924f891074b4971431a6378 
>   src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java b17b983f66ce0ac1ef90b716a28813a505322b17

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
91c1c24448092e1b3454844ab8074ed030383594 
> 
> Diff: https://reviews.apache.org/r/16767/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message