aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe Smith" <yasumo...@gmail.com>
Subject Review Request 16762: Fix TaskPath import in thermos binary
Date Thu, 09 Jan 2014 20:52:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16762/
-----------------------------------------------------------

Review request for Aurora and Brian Wickman.


Bugs: AURORA-26
    https://issues.apache.org/jira/browse/AURORA-26


Repository: aurora


Description
-------

Fix TaskPath import in thermos binary


Diffs
-----

  src/main/python/apache/thermos/bin/thermos.py 334297ae6f1798e01899d80a5fe18da04f36220a 
  src/test/python/apache/thermos/BUILD 38c2f4b8e165f863e5c195b42d90ea1ec00aea0a 
  src/test/python/apache/thermos/bin/BUILD PRE-CREATION 
  src/test/python/apache/thermos/bin/test_thermos.py PRE-CREATION 

Diff: https://reviews.apache.org/r/16762/diff/


Testing
-------

[tw-172-25-27-94 aurora (jsmith/wat)]$ ./pants ./src/test/python/apache/thermos/bin:all
Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/thermos/bin/BUILD:all)])
=============================================================== test session starts ================================================================
platform darwin -- Python 2.7.3 -- pytest-2.5.1
collected 0 items / 1 errors 

====================================================================== ERRORS ======================================================================
_______________________________________ ERROR collecting src/test/python/apache/thermos/bin/test_thermos.py
________________________________________
src/test/python/apache/thermos/bin/test_thermos.py:1: in <module>
>   from apache.thermos.bin import thermos
/var/folders/kk/_7jrv7jd0095tg5x9w1qd8mw0000gp/T/tmpIWqDim/apache/thermos/bin/thermos.py:21:
in <module>
>   from apache.thermos.common.path import TkPath
E   ImportError: cannot import name TkPath
============================================================= 1 error in 0.09 seconds ==============================================================
src.test.python.apache.thermos.bin.test_thermos                                 .....   FAILURE

# updated import statement

[tw-172-25-27-94 aurora (jsmith/wat)]$ ./pants ./src/test/python/apache/thermos/bin:all
Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/thermos/bin/BUILD:all)])
=============================================================== test session starts ================================================================
platform darwin -- Python 2.7.3 -- pytest-2.5.1
collected 0 items 

=================================================================  in 0.15 seconds =================================================================
src.test.python.apache.thermos.bin.test_thermos                                 .....   SUCCESS


Thanks,

Joe Smith


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message