aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Wickman" <wick...@gmail.com>
Subject Re: Review Request 16423: client v2: added implementations of job diff, job inspect.
Date Wed, 08 Jan 2014 23:55:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16423/#review31409
-----------------------------------------------------------


can this diff be generated off the branch with status/create?  that way we just see what needs
to be reviewed.

- Brian Wickman


On Dec. 20, 2013, 1:38 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16423/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2013, 1:38 p.m.)
> 
> 
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implemented client v2 versions of the diff and inspect verbs.
> 
> 
> Diffs
> -----
> 
>   src/main/python/twitter/aurora/client/api/__init__.py 60f4011dda0db17ed57d3499637270d466c1b0b8

>   src/main/python/twitter/aurora/client/cli/BUILD 0a44a218d170a8e6874911befddc0daf744c433e

>   src/main/python/twitter/aurora/client/cli/__init__.py 2c08cf985a3ad9126a544596f895540524af865c

>   src/main/python/twitter/aurora/client/cli/context.py 2ae92ecce8ec3ee2bf66b727e19bc90d1c171eb9

>   src/main/python/twitter/aurora/client/cli/jobs.py e66f1811b14a469a8c232887dd21fcc09dfa4b84

>   src/main/python/twitter/aurora/client/cli/options.py 64a58f8b3e198bb770550c854347220975e74312

>   src/main/python/twitter/aurora/client/options.py 7ced9611c2aec6fec601f1ff61ce4defed3d977f

>   src/test/python/twitter/aurora/client/cli/BUILD 89184b649f8c7807a6f599d6f0026902eed11a6c

>   src/test/python/twitter/aurora/client/cli/test_create.py da2828f73d32e3d3305fddd4224014a9b847ad2a

>   src/test/python/twitter/aurora/client/cli/test_diff.py PRE-CREATION 
>   src/test/python/twitter/aurora/client/cli/test_kill.py 8f8095cd2d1dac9d6d2a9891db16cce1d4227eaf

>   src/test/python/twitter/aurora/client/cli/test_status.py PRE-CREATION 
>   src/test/python/twitter/aurora/client/cli/util.py 46883ecd696b0f6b691831b65bb5e71367cd652a

> 
> Diff: https://reviews.apache.org/r/16423/diff/
> 
> 
> Testing
> -------
> 
> Added new unit tests for "diff"; inspect doesn't do any API calls that aren't already
tested.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message